Skip to content

[FIX] App details returns to apps table, instead of previous page.#18080

Merged
ggazzo merged 1 commit intodevelopfrom
fix/app_info_back
Jul 3, 2020
Merged

[FIX] App details returns to apps table, instead of previous page.#18080
ggazzo merged 1 commit intodevelopfrom
fix/app_info_back

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

Proposed changes

Make it so that when clicking Back returns to the previous loaded page.

Issue(s)

How to test or reproduce

Enter marketplace, select app, click back button. It redirects to the apps page, instead of marketplace.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan added feat: apps area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: bug labels Jul 3, 2020
@tassoevan tassoevan added this to the 3.5.0 milestone Jul 3, 2020
@ggazzo ggazzo modified the milestones: 3.5.0, 3.4.2 Jul 3, 2020
@ggazzo ggazzo merged commit ff7c781 into develop Jul 3, 2020
@ggazzo ggazzo deleted the fix/app_info_back branch July 3, 2020 23:15
gabriellsh added a commit that referenced this pull request Jul 6, 2020
…into new/rewrite_account_profile

* 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat:
  [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)
  [FIX] App details returns to apps table, instead of previous page (#18080)
  [FIX] Clipboard not working when permalinking a pinned message (#18047)
  [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)
  [FIX] Jitsi opening twice (#18111)
  [FIX] Email notifications were still being sent for online users (#18088)
  [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)
gabriellsh added a commit that referenced this pull request Jul 6, 2020
…ocket.Chat into rewrite/user_preferences

* 'new/rewrite_account_profile' of github.com:RocketChat/Rocket.Chat:
  [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)
  [FIX] App details returns to apps table, instead of previous page (#18080)
  [FIX] Clipboard not working when permalinking a pinned message (#18047)
  [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)
  [FIX] Jitsi opening twice (#18111)
  [FIX] Email notifications were still being sent for online users (#18088)
  [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)
@rodrigok rodrigok mentioned this pull request Jul 10, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
ggazzo added a commit that referenced this pull request Jul 28, 2020
* [FIX] Jitsi opening twice (#18111)

* [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)

* [FIX] Avatar ETag missing from User (#18109)

* Handle callback returning promise. (#18102)

* [FIX] Not possible to read encrypted messages after disable E2E on channel level (#18101)

* [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)

* [FIX] Email notifications were still being sent for online users (#18088)

* Bump version to 3.4.1

* [FIX] App details returns to apps table, instead of previous page (#18080)

* [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)

* [FIX] Old Data Migrations breaking upgrades (#18185)

* [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)

* [FIX] SAML login crashing when receiving an array of roles (#18224)

* [FIX] CAS login not merging users with local accounts (#18238)

* Bump version to 3.4.2

* Bump version to 3.5.0-rc.0

* Bump version to 3.5.0-rc.1

* Bump version to 3.5.0-rc.2

* Bump version to 3.5.0-rc.3

* Bump version to 3.5.0-rc.4

* Bump version to 3.5.0

* Bump version to 3.6.0-develop

Co-authored-by: Guilherme Gazzo <[email protected]>
Co-authored-by: Maria Eduarda Cunha <[email protected]>
Co-authored-by: gabriellsh <[email protected]>
Co-authored-by: Renato Becker <[email protected]>
Co-authored-by: Rodrigo Nascimento <[email protected]>
Co-authored-by: Paulo Bernardo <[email protected]>
Co-authored-by: Denis <[email protected]>
Co-authored-by: Omar Chehab <[email protected]>
Co-authored-by: pierre-lehnen-rc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction feat: apps type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants