Skip to content

chore: Rewrite account Sidebar#18046

Merged
ggazzo merged 5 commits intorewrite/accountsfrom
new/account_sidebar_rewrite
Jun 30, 2020
Merged

chore: Rewrite account Sidebar#18046
ggazzo merged 5 commits intorewrite/accountsfrom
new/account_sidebar_rewrite

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh commented Jun 25, 2020 •
edited by ggazzo
Loading

Proposed changes

Rewrote the My Account Sidebar using React.

Issue(s)

How to test or reproduce

Screenshots

before

image

after

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 25, 2020

This pull request introduces 4 alerts and fixes 2 when merging d6daabe into a0f2aac - view on LGTM.com

new alerts:

  • 2 for Duplicate HTML element attributes
  • 2 for Useless assignment to property

fixed alerts:

  • 1 for Duplicate HTML element attributes
  • 1 for Useless assignment to property

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 30, 2020

This pull request introduces 4 alerts and fixes 2 when merging 234fa85 into 0c26dca - view on LGTM.com

new alerts:

  • 2 for Duplicate HTML element attributes
  • 2 for Useless assignment to property

fixed alerts:

  • 1 for Duplicate HTML element attributes
  • 1 for Useless assignment to property

@ggazzo ggazzo changed the base branch from develop to rewrite/accounts June 30, 2020 13:47
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 30, 2020

This pull request introduces 4 alerts and fixes 2 when merging 234fa85 into 1157075 - view on LGTM.com

new alerts:

  • 2 for Duplicate HTML element attributes
  • 2 for Useless assignment to property

fixed alerts:

  • 1 for Duplicate HTML element attributes
  • 1 for Useless assignment to property

@ggazzo ggazzo force-pushed the new/account_sidebar_rewrite branch from a1223ea to 3ed2f36 Compare June 30, 2020 17:22
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 30, 2020

This pull request fixes 2 alerts when merging 3ed2f36 into 1157075 - view on LGTM.com

fixed alerts:

  • 1 for Duplicate HTML element attributes
  • 1 for Useless assignment to property

@ggazzo ggazzo merged commit 0c9b22a into rewrite/accounts Jun 30, 2020
@ggazzo ggazzo deleted the new/account_sidebar_rewrite branch June 30, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabriellsh @ggazzo