Skip to content

[FIX] Don't show agent info in the transcript if the setting is disabled#18044

Merged
renatobecker merged 2 commits intoRocketChat:developfrom
antkaz:hide-agent-info
Jul 20, 2020
Merged

[FIX] Don't show agent info in the transcript if the setting is disabled#18044
renatobecker merged 2 commits intoRocketChat:developfrom
antkaz:hide-agent-info

Conversation

@antkaz
Copy link
Copy Markdown
Contributor

@antkaz antkaz commented Jun 25, 2020

Proposed changes

If the parameter Show agent info is disabled then to transcript for the user displayed agent's username.

Issue(s)

How to test or reproduce

  1. Enable an option Show agent info
  2. Create Livechat
  3. Close livechat
  4. Send transcript to the user. Agent name will be available for the user in the transcript
  5. Disable the option Show agent info
  6. Repeat step 2-4. Agent name will not be available for the user in the transcript. The user will see Agent

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@renatobecker renatobecker self-assigned this Jun 25, 2020
@renatobecker renatobecker added this to the 3.5.0 milestone Jun 25, 2020
@renatobecker renatobecker changed the title [FIX] Don't show agent info the in transcript if the setting is disabled [FIX] Don't show agent info in the transcript if the setting is disabled Jul 20, 2020
@renatobecker renatobecker merged commit 6674257 into RocketChat:develop Jul 20, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants