[NEW] Ability to configure Jitsi room options via new setting URL Suffix#17950
Merged
rodrigok merged 3 commits intoRocketChat:developfrom Jun 19, 2020
Merged
Conversation
12 tasks
rodrigok
changed the title
URL Suffix
rodrigok
requested changes
Jun 19, 2020
Member
rodrigok
left a comment
rodrigok
left a comment
There was a problem hiding this comment.
Jitsi_URL_Room_Suffix is missing on en.i18n.json file, please fix the review or give us access to push to your repository.
fthiery
force-pushed
the
add-jitsi-suffix-setting
branch
from
833a1a1 to
1d14a82
Compare
Jisti supports passing configuration overrides (for example #config.startAudioOnly=false), this suffix configuration option makes it possible to customize the behaviour of new jitsi rooms easily.
fthiery
force-pushed
the
add-jitsi-suffix-setting
branch
from
1d14a82 to
2868a09
Compare
Contributor
Author
|
I applied your suggestions, squashed and rebased on latest develop |
Member
|
@fthiery awesome, but it's still missing the translation key, can you add? |
Contributor
Author
|
Done; not sure that's how it's supposed to be done, please check. |
rodrigok
reviewed
Jun 19, 2020
Co-authored-by: Rodrigo Nascimento <[email protected]>
rodrigok
approved these changes
Jun 19, 2020
Contributor
Author
|
Will you take care of squashing and rebasing ? |
Member
|
@fthiery yes, we always use squash to merge PRs. Thanks |
Merged
This was referenced Jul 3, 2020
|
Does this also work when jwt auth is enabled? |
Contributor
Author
Probably not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I want the jitsi meetings (hosted on the community/public jisti server) to start with audio only. Jisti supports passing configuration overrides (for example #config.startAudioOnly=true), so adding a suffix configuration option would make it possible to customize the behaviour of new jitsi rooms easily.
See the possible overrides : https://github.com/jitsi/jitsi-meet/blob/c73ba372022db0bb967d628b136934219d8c4fec/config.js#L83
Issue(s)
See #2044
Types of changes
Checklist
Changelog
add jitsi url suffix so that room configuration can be overriden (e.g. disable video)
Further comments
I'm not sure whether this would break things with e.g. jwt auth, and no translation has been done.