[IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate variables#17669
Merged
sampaiodiego merged 3 commits intoRocketChat:developfrom Jun 13, 2020
jazztickets:notification-delay-split
Merged
[IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate variables#17669sampaiodiego merged 3 commits intoRocketChat:developfrom jazztickets:notification-delay-split
NOTIFICATIONS_SCHEDULE_DELAY into three separate variables#17669sampaiodiego merged 3 commits intoRocketChat:developfrom
jazztickets:notification-delay-split
Conversation
…ariables for the statuses 'online', 'away', and 'offline'. This change also allows disabling the scheduled notification for each status by setting the delay to -1.
sampaiodiego
approved these changes
Jun 13, 2020
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
This is interesting, thanks for your contribution.. I have some additional changes to this, but I don't see any reason to not merge this. Thanks again =)
ggazzo
added a commit
that referenced
this pull request
Jun 17, 2020
…o threads-alpha * 'threads-alpha' of github.com:RocketChat/Rocket.Chat: (23 commits) [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839) [FIX] Undesirable message updates after user saving profile (#17930) Remove unused accounts-js integration (#17921) [IMPROVE] Don't send emails to online users and remove delay when away/idle (#17907) [IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate variables (#17669) correct outdated dev start info [IMPROVE] Rewrite Federation Dashboard (#17900) [FIX] Duplicated placeholderaceholder (#17898) Wrap components with React.memo (#17899) [FIX] Some Login Buttons disappear after refreshing OAuth Services (#17808) Change some components' location (#17893) [IMPROVE] Rewrite admin sidebar in React (#17801) Always initialize CIRCLE_BRANCH env var on CI (#17874) [NEW] Blocked Media Types setting (#17617) [FIX] Reorder hljs (#17854) [FIX] SAML LogoutRequest sending wrong NameID (#17860) [FIX] Apps room events losing data (#17827) [FIX] Importers progress sending too much update events to clients (#17857) [FIX] Omnichannel message link is broken in email notifications (#17843) [FIX] Logic for room type was inverted in edit panel (#17851) (#17853) ...
Merged
rodrigok
changed the title
NOTIFICATIONS_SCHEDULE_DELAY into three separate variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch builds upon PR #17357 by allowing the notification delay to be customized for 'online', 'away' and 'offline' statuses via environment variables. It also allows each notification type to be disabled by setting the delay to -1.
Issue(s)
This aims to fix issue #17492, although a proper fix would allow it to be configured via the Admin section. The problem is most users don't want to be emailed when they're online, regardless if they've read the messages or not. The current workaround is setting NOTIFICATIONS_SCHEDULE_DELAY to an extremely high value, though that doesn't really solve the issue.
Types of changes
Checklist
Changelog
Now the email notification delay can now be customized with the following environment variables:
NOTIFICATIONS_SCHEDULE_DELAY_ONLINENOTIFICATIONS_SCHEDULE_DELAY_AWAYNOTIFICATIONS_SCHEDULE_DELAY_OFFLINE