[IMPROVE] Custom sounds refactor#17485
Merged
ggazzo merged 28 commits intoadmin-refactorfrom May 5, 2020
Merged
Conversation
|
This pull request introduces 2 alerts when merging eccef79 into 84169b6 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging eccef79 into 60e1452 - view on LGTM.com new alerts:
|
MartinSchoeler
commented
May 4, 2020
| <Box display='flex' flexDirection='row' mbs='none'> | ||
| <Margins inline='x4'> | ||
| <Button square onClick={clickUpload}><Icon name='upload' size='x20'/></Button> | ||
| {(sound && sound.name) || 'none'} |
Member
Author
There was a problem hiding this comment.
Need a better element to add this info, any suggestions?
|
This pull request introduces 1 alert and fixes 2 when merging c0b2781 into db7b469 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 2 alerts when merging c5101b5 into db7b469 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging e78f4a7 into db7b469 - view on LGTM.com fixed alerts:
|
MartinSchoeler
changed the title
gabriellsh
added a commit
that referenced
this pull request
May 6, 2020
…to integrations * 'admin-refactor' of github.com:RocketChat/Rocket.Chat: fix all paddings and mixed content between screens (#17538) [IMPROVE] Add new webhooks to the Omnichannel integration feature (#17503) [BREAK] Remove deprecated Omnichannel Knowledge Base feature (#17387) [FIX] Reactions may present empty names of who reacted when using Real Names (#17536) [IMPROVE] Custom sounds refactor (#17485) Allow to filter omnichannel analytics dashboards per departments. (#17463) [FIX] Uncessary updates on Settings, Roles and Permissions on startup (#17160) [NEW] Add the ability to send Livechat offline messages to a channel (#17442) [FIX] Federation attachment URL for audio and video files (#16430) [NEW] Add Livechat website URL to the offline message e-mail (#17429)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: