Skip to content

Regression: Fix mem usage with more than one argument#17391

Merged
ggazzo merged 1 commit intodevelopfrom
fix-mem
Apr 23, 2020
Merged

Regression: Fix mem usage with more than one argument#17391
ggazzo merged 1 commit intodevelopfrom
fix-mem

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego commented Apr 22, 2020

mem version v6 has changed the default cache strategy and now it caches only the first argument by default.

So I have changed cacheKey where we use mem for functions with more than one argument to use JSON.stringify

I have also improved to get only the needed fields on has permission functions.

@sampaiodiego sampaiodiego requested review from ggazzo and rodrigok April 22, 2020 20:02
@ggazzo ggazzo merged commit ac5329f into develop Apr 23, 2020
@ggazzo ggazzo deleted the fix-mem branch April 23, 2020 01:25
gabriellsh added a commit that referenced this pull request Apr 23, 2020
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix mem usage with more than one argument (#17391)
@sampaiodiego sampaiodiego added this to the 3.1.2 milestone Apr 24, 2020
ggazzo added a commit that referenced this pull request Apr 27, 2020
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404)
  [FIX] Allowing blocking a user on channels (#17406)
  Fix moving-to-a-single-codebase link in README (#17297)
  Regression: Fix mem usage with more than one argument (#17391)
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
ggazzo added a commit that referenced this pull request Apr 28, 2020
…to adm/custom_status

* 'admin-refactor' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Redesign Administration > Invites (#17390)
  Bump version to 3.1.2
  [FIX] LDAP error when trying to add room with spaces in the name (#17453)
  Regression: Add missing cacheKey to mem (#17430)
  [FIX] Empty Incoming webhook script field (#17422)
  [FIX] LDAP Sync error (#17417)
  [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404)
  [FIX] Allowing blocking a user on channels (#17406)
  Regression: Fix mem usage with more than one argument (#17391)
  [FIX] Web Client memory leak caused by the Emoji library (#17320)
  [FIX] Omnichannel room info panel opening whenever a message is sent (#17348)
  [FIX] New user added by admin doesn't receive random password email (#17249)
  [FIX] LDAP error when trying to add room with spaces in the name (#17453)
  Complement Guest role restrictions for Enterprise (#17393)
  Regression: Add missing cacheKey to mem (#17430)
  Remove `@typescript-eslint/explicit-function-return-type` rule (#17428)
  [FIX] Empty Incoming webhook script field (#17422)
  [FIX] LDAP Sync error (#17417)
  [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404)
ggazzo added a commit that referenced this pull request May 6, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  [IMPROVE] [Apps-Engine] App user as the default notifier (#17050)
  [NEW] [Apps-Engine] New Livechat event handlers (#17033)
  [FIX] Change email verification label (#17450)
  Priority system messages were always created (#17479)
  Bump version to 3.3.0-develop
  Bump version to 3.2.0
  Bump version to 3.1.2
  [FIX] LDAP error when trying to add room with spaces in the name (#17453)
  Regression: Add missing cacheKey to mem (#17430)
  [FIX] Empty Incoming webhook script field (#17422)
  [FIX] LDAP Sync error (#17417)
  [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404)
  [FIX] Allowing blocking a user on channels (#17406)
  Regression: Fix mem usage with more than one argument (#17391)
  [FIX] Web Client memory leak caused by the Emoji library (#17320)
  [FIX] Omnichannel room info panel opening whenever a message is sent (#17348)
  [FIX] New user added by admin doesn't receive random password email (#17249)
  Bump version to 3.2.0-rc.2
  [FIX] LDAP error when trying to add room with spaces in the name (#17453)
  Complement Guest role restrictions for Enterprise (#17393)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants