Skip to content

[NEW] [ENTERPRISE] Restrict the permissions configuration for guest users #17333

Merged
sampaiodiego merged 20 commits intodevelopfrom
new.guest-role-refactor
Apr 21, 2020
Merged

[NEW] [ENTERPRISE] Restrict the permissions configuration for guest users #17333
sampaiodiego merged 20 commits intodevelopfrom
new.guest-role-refactor

Conversation

@pierre-lehnen-rc
Copy link
Copy Markdown
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Apr 16, 2020

Changelog Description

The Guest role is blocked for edition on the EE version. This will allow the EE customers to receive licenses with extra seats for Guests for free. The CE version continues to have the Guest role configurable.

@engelgabriel engelgabriel added this to the 3.2.0 milestone Apr 20, 2020
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review April 21, 2020 05:31
rodrigok
rodrigok previously approved these changes Apr 21, 2020
Copy link
Copy Markdown
Member

@rodrigok rodrigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is approved

@rodrigok rodrigok changed the title [NEW] Guest Role Refactor [NEW] [ENTERPRISE] Restrict the permissions configuration for guest users Apr 21, 2020
import { settings } from '../../../settings';
import { passwordPolicy } from '../lib/passwordPolicy';
import { validateEmailDomain } from '../lib';
import { validateUserRoles } from '../../../../ee/app/authorization/server/validateUserRoles';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to review if we'll want this hard dependency on EE

@sampaiodiego sampaiodiego merged commit 0a76974 into develop Apr 21, 2020
@sampaiodiego sampaiodiego deleted the new.guest-role-refactor branch April 21, 2020 08:22
gabriellsh added a commit that referenced this pull request Apr 22, 2020
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  [FIX] 2FA not showing codes for Spanish translation (#17378)
  [NEW] [ENTERPRISE] Restrict the permissions configuration for guest users  (#17333)
  [NEW] Federation event for when users left rooms (#17091)
  [FIX] CSV Importer fails when there are no users to import (#16790)
  Import slack's mpims as direct rooms instead of private groups (#17206)
  [FIX] SAML Idp Initiated Logout Error (#17324)
  [NEW] Better Push and Email Notification logic (#17357)
  [NEW] Error page when browser is not supported (#17372)
  [NEW] [ENTERPRISE] Omnichannel queue priorities (#17141)
  [IMPROVE] Change the SAML metadata order to conform to XSD specification (#15488)
  [IMPROVE] Filter markdown in notifications (#9995)
  [IMPROVE] User gets UI feedback when message is pinned or unpinned (#16056)
  Remove set as alias setting (#16343)
  [IMPROVE] Add `file-title` and `file-desc` as new filter tag options on message search (#16858)
  [NEW]  Add ability to set tags in the Omnichannel room closing dialog (#17254)
  [FIX] Show active admin and user account menu item (#17047)
  [NEW] [ENTERPRISE] Allows to set a group of departments accepted for forwarding chats (#17335)
  [FIX] Prevent user from getting stuck on login, if there is some bad fname (#17331)
  [FIX] Remove properties from users.info response (#17238)
  Bump version to 3.1.1
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants