[FIX] Popover component doesn't have scroll#17198
Merged
ggazzo merged 5 commits intoRocketChat:developfrom Apr 14, 2020
Merged
Conversation
Fix lint Fix lint
Contributor
Author
|
@sampaiodiego Could you check if it's fine? Are there any other modifications to be done? |
Member
|
thanks @Nikhil713 .. I've asked review from our frontend guys :D |
sampaiodiego
requested review from
a team
and removed request for
ggazzo and
tassoevan
gabriellsh
reviewed
Apr 9, 2020
| position: absolute; | ||
|
|
||
| display: flex; | ||
| display: -webkit-box; |
Contributor
Author
There was a problem hiding this comment.
I didn't notice the flex-direction property. Only display: -webkit-box seemed to work. I have corrected the error.
|
|
||
| flex-direction: column; | ||
|
|
||
| height: 70%; |
Member
There was a problem hiding this comment.
When I have a tall screen/fewer buttons in the popover, doesn't this make it bigger than needed?
Contributor
Author
There was a problem hiding this comment.
Yes, it does. I have included a media query to adjust the height in case of taller screens. Hope that fixes the issue.
Member
There was a problem hiding this comment.
We still have a problem, imagine I have another popover with only one button, it'd still be bigger than the content. Why don't you try max-height? Then (in theory) you won't need anything else, it'll only shrink when the popover is bigger than 70% of its parent.
Contributor
Author
There was a problem hiding this comment.
I have made the changes and it works correctly now. Thanks a lot for the pointers :)
gabriellsh
requested changes
Apr 13, 2020
|
|
||
| flex-direction: column; | ||
|
|
||
| height: 70%; |
Member
There was a problem hiding this comment.
We still have a problem, imagine I have another popover with only one button, it'd still be bigger than the content. Why don't you try max-height? Then (in theory) you won't need anything else, it'll only shrink when the popover is bigger than 70% of its parent.
gabriellsh
previously approved these changes
Apr 14, 2020
gabriellsh
added a commit
that referenced
this pull request
Apr 15, 2020
…mailer * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) [FIX] translation for nl (#16742) [FIX] No maxlength defined for custom user status (#16534) [FIX] Directory users email sort button (#16606) [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405) [FIX] Email not verified message (#16236) [FIX] Directory default tab (#17283) Update ru.i18n.json (#16869) ...
gabriellsh
added a commit
that referenced
this pull request
Apr 15, 2020
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] "Invalid Invite" message when registration is disabled (#17226) [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198)
ggazzo
added a commit
that referenced
this pull request
Apr 15, 2020
…dm/mailer * 'adm/mailer' of github.com:RocketChat/Rocket.Chat: (79 commits) removed unecessary prop Fixed sendMail function Removed Log, Success message Permissions added route component [FIX] "Invalid Invite" message when registration is disabled (#17226) Added route, error handling. [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) ...
dudizilla
added a commit
that referenced
this pull request
Apr 21, 2020
…nto view-logs * 'develop' of https://github.com/RocketChat/Rocket.Chat: (31 commits) Fixed componentes width (#17322) [IMPROVE] Administration -> Mailer Rewrite to React. (#17191) Regression: Storybook added flowrouter group mock (#17321) [NEW] Feature/custom oauth mail field and interpolation for mapped fields (#15690) [FIX] "Invalid Invite" message when registration is disabled (#17226) [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) [FIX] translation for nl (#16742) [FIX] No maxlength defined for custom user status (#16534) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17185
After adding scroll