[FIX] Uncessary updates on Settings, Roles and Permissions on startup#17160
Merged
sampaiodiego merged 14 commits intodevelopfrom May 4, 2020
Merged
[FIX] Uncessary updates on Settings, Roles and Permissions on startup#17160sampaiodiego merged 14 commits intodevelopfrom
sampaiodiego merged 14 commits intodevelopfrom
Conversation
# Conflicts: # app/settings/client/lib/settings.ts # app/settings/lib/settings.ts # app/settings/server/functions/settings.ts
rodrigok
force-pushed
the
settings-permissions-roles-updates
branch
from
f5dec1a to
9bbf059
Compare
|
This pull request introduces 1 alert when merging 9bbf059 into ff8017a - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging dd6932a into ff8017a - view on LGTM.com new alerts:
|
rodrigok
force-pushed
the
settings-permissions-roles-updates
branch
from
6a05633 to
dde16b0
Compare
MarcosSpessatto
previously approved these changes
Apr 6, 2020
ggazzo
reviewed
Apr 14, 2020
| }, { fields: { _id: 1 } }); | ||
|
|
||
| if (!existent) { | ||
| Permissions.upsert({ _id: permissionId }, { $set: permission }); |
Member
Author
There was a problem hiding this comment.
The permission may exist with different properties
Member
|
why not use the rocketchat version to check if should reprocess, only process the settings if we upgraded rocket.chat? |
Member
Author
Maybe a good idea and a later improvement. But without this improvement as well it will reprocess all the settings again on each upgrade. |
|
This pull request introduces 1 alert when merging c1e1f85 into c05eac5 - view on LGTM.com new alerts:
|
sampaiodiego
requested changes
May 4, 2020
sampaiodiego
approved these changes
May 4, 2020
ggazzo
added a commit
that referenced
this pull request
May 5, 2020
…n-refactor * 'develop' of github.com:RocketChat/Rocket.Chat: Allow to filter omnichannel analytics dashboards per departments. (#17463) [FIX] Uncessary updates on Settings, Roles and Permissions on startup (#17160) [NEW] Add the ability to send Livechat offline messages to a channel (#17442) [FIX] Federation attachment URL for audio and video files (#16430) [NEW] Add Livechat website URL to the offline message e-mail (#17429)
ggazzo
added a commit
that referenced
this pull request
May 6, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits) [FIX] Invalid CSS syntax (#17541) [NEW] Rewrite admin pages (#17388) [FIX] Replace postcss Meteor package (#15929) [FIX] Increasing highlight time in 3 seconds (#17540) [IMPROVE] Add new webhooks to the Omnichannel integration feature (#17503) [BREAK] Remove deprecated Omnichannel Knowledge Base feature (#17387) [FIX] Reactions may present empty names of who reacted when using Real Names (#17536) Allow to filter omnichannel analytics dashboards per departments. (#17463) [FIX] Uncessary updates on Settings, Roles and Permissions on startup (#17160) [NEW] Add the ability to send Livechat offline messages to a channel (#17442) [FIX] Federation attachment URL for audio and video files (#16430) [NEW] Add Livechat website URL to the offline message e-mail (#17429) LingoHub based on develop (#17520) RegExp improvements suggested by LGTM (#17500) [FIX] Replace obsolete X-FRAME-OPTIONS header on Livechat route (#17419) [FIX] LDAP login error on Enterprise version (#17497) [IMPROVE] [Apps-Engine] App user as the default notifier (#17050) [NEW] [Apps-Engine] New Livechat event handlers (#17033) [FIX] Change email verification label (#17450) Priority system messages were always created (#17479) ...
gabriellsh
added a commit
that referenced
this pull request
May 6, 2020
…to integrations * 'admin-refactor' of github.com:RocketChat/Rocket.Chat: fix all paddings and mixed content between screens (#17538) [IMPROVE] Add new webhooks to the Omnichannel integration feature (#17503) [BREAK] Remove deprecated Omnichannel Knowledge Base feature (#17387) [FIX] Reactions may present empty names of who reacted when using Real Names (#17536) [IMPROVE] Custom sounds refactor (#17485) Allow to filter omnichannel analytics dashboards per departments. (#17463) [FIX] Uncessary updates on Settings, Roles and Permissions on startup (#17160) [NEW] Add the ability to send Livechat offline messages to a channel (#17442) [FIX] Federation attachment URL for audio and video files (#16430) [NEW] Add Livechat website URL to the offline message e-mail (#17429)
3 tasks
ggazzo
added a commit
that referenced
this pull request
May 7, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix Avatar Url Provider when CDN_PREFIX_ALL is false (#17542) [FIX] Invalid CSS syntax (#17541) [NEW] Rewrite admin pages (#17388) [FIX] Replace postcss Meteor package (#15929) [FIX] Increasing highlight time in 3 seconds (#17540) [IMPROVE] Add new webhooks to the Omnichannel integration feature (#17503) [BREAK] Remove deprecated Omnichannel Knowledge Base feature (#17387) [FIX] Reactions may present empty names of who reacted when using Real Names (#17536) Allow to filter omnichannel analytics dashboards per departments. (#17463) [FIX] Uncessary updates on Settings, Roles and Permissions on startup (#17160) [NEW] Add the ability to send Livechat offline messages to a channel (#17442) [FIX] Federation attachment URL for audio and video files (#16430) [NEW] Add Livechat website URL to the offline message e-mail (#17429) LingoHub based on develop (#17520) RegExp improvements suggested by LGTM (#17500) [FIX] Replace obsolete X-FRAME-OPTIONS header on Livechat route (#17419) [FIX] LDAP login error on Enterprise version (#17497)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.