[FIX] Omnichannel endpoint inquiries.getOne returning only queued inquiries#17132
Merged
sampaiodiego merged 2 commits intodevelopfrom Apr 2, 2020
Merged
Conversation
MarcosSpessatto
approved these changes
Apr 2, 2020
sampaiodiego
changed the title
inquiries.getOne returning only queued inquiries
gabriellsh
added a commit
that referenced
this pull request
Apr 2, 2020
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: (304 commits) [FIX] Omnichannel endpoint `inquiries.getOne` returning only queued inquiries (#17132) Fix design review (#17133) Regression: Direct message creation by REST (#17109) Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128) Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127) Regression: IE11 Support (#17125) [FIX] Federation delete room event not being dispatched (#16861) [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878) New Troubleshoot section for disabling features (#17114) Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118) [NEW] Discussions: Inherit the public status of parent channel (#17070) Regression: fix fuselage import, remove directory css (#17116) [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115) Regression: Remove old and closed Omnichannel inquiries (#17113) [FIX] Member's list only filtering users already on screen (#17110) Single codebase announcement (#17081) [NEW] Directory page refactored, new user's bio field (#17043) [NEW] Sort List, View Mode and Group by revamp (#17103) Regression: Files were been deleted when deleting users as last members of private rooms (#17111) Regression: Block users was not possible for 1:1 DMs (#17105) ...
sampaiodiego
pushed a commit
that referenced
this pull request
Apr 3, 2020
sampaiodiego
pushed a commit
that referenced
this pull request
Apr 3, 2020
Merged
ggazzo
added a commit
that referenced
this pull request
Apr 3, 2020
…cketChat/Rocket.Chat into wrapper-call-meteor-methods-over-rest * 'wrapper-call-meteor-methods-over-rest' of github.com:RocketChat/Rocket.Chat: Fix login not authenticating the socket connection Add method name to the endpoints to track on metrics Wrap DDP calls on transport layer New metric to track oplog queue (#17142) [FIX] Option BYPASS_OPLOG_VALIDATION not working (#17143) [FIX] Omnichannel endpoint `inquiries.getOne` returning only queued inquiries (#17132)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an agent takes a new chat, the server was returning
nullto the client, which was bringing a very bad UX to the agent that had to refresh the page to be able to start chatting.This was happening because the endpoint that was returning the inquiry was filtering only inquiries with the
status = queued, but when the agent takes the inquiry its status changes totaken.