[FIX] Show active admin and user account menu item#17047
Merged
rodrigok merged 10 commits intoRocketChat:developfrom Apr 21, 2020
Merged
[FIX] Show active admin and user account menu item#17047rodrigok merged 10 commits intoRocketChat:developfrom
rodrigok merged 10 commits intoRocketChat:developfrom
Conversation
|
|
Tks @rodrigok fot the tips! 🚀 👊 This changes made current active menu item highlight on the pages bellow - Connectivity Services - Federation Dashboard
rodrigok
previously approved these changes
Mar 27, 2020
Member
|
Looks like admin routes definition has changed, causing conflicts to this PR.. can you please take a look? maybe @tassoevan can give a little help as he changed them on #17209 |
Contributor
Author
|
Hey @tassoevan, did you change route '/admin/info' param name? Before section param returns 'admin-info', but now just 'admin'. I control the active menu item with this prop param. |
Member
|
@hullen I don't think so. At least it seems correctly defined in |
Contributor
Author
|
tassoevan
added
the
area: ui/ux
Member
|
Would this replace the PR #13111? |
Contributor
Author
Yes, my PR cover itens this PR too. ;) But with another aproach to solve this. |
tassoevan
approved these changes
Apr 20, 2020
gabriellsh
added a commit
that referenced
this pull request
Apr 22, 2020
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] 2FA not showing codes for Spanish translation (#17378) [NEW] [ENTERPRISE] Restrict the permissions configuration for guest users (#17333) [NEW] Federation event for when users left rooms (#17091) [FIX] CSV Importer fails when there are no users to import (#16790) Import slack's mpims as direct rooms instead of private groups (#17206) [FIX] SAML Idp Initiated Logout Error (#17324) [NEW] Better Push and Email Notification logic (#17357) [NEW] Error page when browser is not supported (#17372) [NEW] [ENTERPRISE] Omnichannel queue priorities (#17141) [IMPROVE] Change the SAML metadata order to conform to XSD specification (#15488) [IMPROVE] Filter markdown in notifications (#9995) [IMPROVE] User gets UI feedback when message is pinned or unpinned (#16056) Remove set as alias setting (#16343) [IMPROVE] Add `file-title` and `file-desc` as new filter tag options on message search (#16858) [NEW] Add ability to set tags in the Omnichannel room closing dialog (#17254) [FIX] Show active admin and user account menu item (#17047) [NEW] [ENTERPRISE] Allows to set a group of departments accepted for forwarding chats (#17335) [FIX] Prevent user from getting stuck on login, if there is some bad fname (#17331) [FIX] Remove properties from users.info response (#17238) Bump version to 3.1.1 ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8500
Added support to show active sidebar menu item on the user account and admin panels.