Skip to content

[NEW] Adds ability for Rocket.Chat Apps to create discussions#16683

Merged
sampaiodiego merged 13 commits intodevelopfrom
discussion-create
Apr 17, 2020
Merged

[NEW] Adds ability for Rocket.Chat Apps to create discussions#16683
sampaiodiego merged 13 commits intodevelopfrom
discussion-create

Conversation

@marceloschmidt
Copy link
Copy Markdown
Member

@marceloschmidt marceloschmidt commented Feb 21, 2020

Depends on RocketChat/Rocket.Chat.Apps-engine#229
Converts new apps-engine properties to rocket.chat models

@marceloschmidt marceloschmidt mentioned this pull request Mar 28, 2020
Merged
@shiqimei shiqimei self-assigned this Mar 31, 2020
@shiqimei
Copy link
Copy Markdown
Contributor

shiqimei commented Mar 31, 2020

Hi @marceloschmidt ! Have you created an app to test if it works? Would you mind sharing the app here? Thanks!

@marceloschmidt
Copy link
Copy Markdown
Member Author

marceloschmidt commented Mar 31, 2020 •
edited
Loading

The app is not ready yet, but you can easily test it with the following code:

const discussion = await modify.getCreator().startDiscussion()
  .setParentRoom(await read.getRoomReader().getById('your_room_id') as IRoom)
  .setReply(`This is the first message sent in the discussion`)
  .setDisplayName(`Discussion name`)
  .setSlugifiedName(`a_random_id`)
  .setCreator(await read.getUserReader().getById('your_user_id') as IUser);
const rid = await modify.getCreator().finish(discussion);
console.log(rid);

@marceloschmidt
Copy link
Copy Markdown
Member Author

marceloschmidt commented Mar 31, 2020

And you can add a .setParentMessage(await read.getMessageReader().getById('a_message_id') as IMessage) to make it reply to a specific message.

shiqimei
shiqimei previously approved these changes Apr 1, 2020
View reviewed changes
@d-gubert d-gubert added this to the 3.2.0 milestone Apr 3, 2020
@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Apr 13, 2020

just making sure nothing has changed in the past two weeks.. can we go ahead and merge this?

@d-gubert d-gubert changed the title Adds ability for apps to create discussions [NEW] Adds ability for Rocket.Chat Apps to create discussions Apr 17, 2020
@sampaiodiego sampaiodiego merged commit 9cc76d9 into develop Apr 17, 2020
@sampaiodiego sampaiodiego deleted the discussion-create branch April 17, 2020 21:38
gabriellsh added a commit that referenced this pull request Apr 18, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into adm/…
3855ca5 
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Bump https-proxy-agent from 2.2.1 to 2.2.4 (#17323)
  [NEW] Adds ability for Rocket.Chat Apps to create discussions (#16683)
  Add possibility to sort the Omnichannel current chats list by column (#17347)
  [IMPROVE] Redesign Administration > Import (#17289)
dudizilla added a commit that referenced this pull request Apr 21, 2020
@dudizilla
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
68342c7 
…nto view-logs

* 'develop' of https://github.com/RocketChat/Rocket.Chat:
  [NEW] Allow to send Agent custom fields through the Omnichannel CRM integration (#16286)
  [FIX] Spotify embed and collapsed (#17356)
  Improve: Better Push Notification code (#17338)
  LingoHub Update 🚀 (#17365)
  [FIX] Allow Screensharing in BBB Iframe (#17290)
  [NEW] Make the header for rooms clickable (#16762)
  Import data pagination (#17355)
  Allow to set a comment when forwarding omnichannel rooms. (#17353)
  [FIX] Web Client memory leak caused by the Emoji library (#17320)
  [FIX] Omnichannel room info panel opening whenever a message is sent (#17348)
  [FIX] New user added by admin doesn't receive random password email (#17249)
  Bump https-proxy-agent from 2.2.1 to 2.2.4 (#17323)
  [NEW] Adds ability for Rocket.Chat Apps to create discussions (#16683)
  Add possibility to sort the Omnichannel current chats list by column (#17347)
  [IMPROVE] Redesign Administration > Import (#17289)
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-gubert d-gubert d-gubert approved these changes

+1 more reviewer

@shiqimei shiqimei shiqimei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@shiqimei shiqimei

Labels

feat: apps

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@marceloschmidt @shiqimei @sampaiodiego @d-gubert