Skip to content

[FIX] Can't click on room's actions menu of sidebar list when in search mode#16548

Merged
sampaiodiego merged 1 commit intoRocketChat:developfrom
vegeta999:action_fix
May 21, 2020
Merged

[FIX] Can't click on room's actions menu of sidebar list when in search mode#16548
sampaiodiego merged 1 commit intoRocketChat:developfrom
vegeta999:action_fix

Conversation

@vegeta999
Copy link
Copy Markdown
Contributor

@vegeta999 vegeta999 commented Feb 10, 2020

Initially the action clicking action button of any search result made the list disappear.
Now the the list doesn't go off and user can perform actions using the button.
Fixes #16436
Then:
ezgif com-video-to-gif(3)
Now:
ezgif com-video-to-gif(9)

@vegeta999
Copy link
Copy Markdown
Contributor Author

@gabriellsh please review !

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ggazzo ggazzo added this to the 3.3.0 milestone May 8, 2020
@rodrigok rodrigok changed the title [FIX]: User is now able to open the actions in search results. [FIX] User is now able to open the actions in search results May 20, 2020
@rodrigok rodrigok changed the title [FIX] User is now able to open the actions in search results [FIX] Can't click on room's actions menu of sidebar list when in search mode May 20, 2020
@rodrigok rodrigok requested a review from dudizilla May 20, 2020 19:07
@sampaiodiego sampaiodiego merged commit c35811d into RocketChat:develop May 21, 2020
This was referenced May 28, 2020
gabriellsh added a commit that referenced this pull request May 29, 2020
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  Regression: Fix Unread bar design (#17750)
  Regression: Adjusting spaces between OAuth login buttons (#17745)
  Improved thread margins for clarity
  Regression: Scroll on admin user info (#17711)
  Regression: Removed status border on mentions list (#17741)
  Regression: Force unread-rooms bar to appears over the room list (#17728)
  [NEW][APPS-ENGINE] Essentials mechanism (#17656)
  Regression: Fix error preventing creation of group DMs (#17726)
  [FIX] SAML IDP initiated logout error (#17482)
  Regression: Threads list was fetching all threads (#17716)
  Regression: Add missing return to afterSaveMessage callbacks (#17715)
  [FIX] Missing dropdown to select custom status color on user's profile (#16537)
  [FIX] Password reset/change accepting current password as new password (#16331)
  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)
  Upgrade Livechat Widget version to 1.5.0 (#17710)
  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)
  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)
  Update Fuselage version (#17708)
  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)
  Regression: Status presence  color (#17707)
  ...
ggazzo added a commit that referenced this pull request Jun 3, 2020
…/new-threads* 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) Submit a payload to the release service when a release happens (#17775)  Regression: Fix Unread bar design (#17750)  Regression: Adjusting spaces between OAuth login buttons (#17745)  Improved thread margins for clarity  Regression: Scroll on admin user info (#17711)  Regression: Removed status border on mentions list (#17741)  Regression: Force unread-rooms bar to appears over the room list (#17728)  [NEW][APPS-ENGINE] Essentials mechanism (#17656)  Regression: Fix error preventing creation of group DMs (#17726)  [FIX] SAML IDP initiated logout error (#17482)  Regression: Threads list was fetching all threads (#17716)  Regression: Add missing return to afterSaveMessage callbacks (#17715)  [FIX] Missing dropdown to select custom status color on user's profile (#16537)  [FIX] Password reset/change accepting current password as new password (#16331)  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)  Upgrade Livechat Widget version to 1.5.0 (#17710)  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)  Update Fuselage version (#17708)  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In search suggestion list, action button is inactive, event pops up to click.

5 participants