[FIX] users.info endpoint not handling the error if the user does not exist#16495
Merged
sampaiodiego merged 3 commits intodevelopfrom Feb 20, 2020
Merged
[FIX] users.info endpoint not handling the error if the user does not exist#16495sampaiodiego merged 3 commits intodevelopfrom
sampaiodiego merged 3 commits intodevelopfrom
Conversation
sampaiodiego
previously approved these changes
Feb 20, 2020
sampaiodiego
changed the title
sampaiodiego
force-pushed
the
fix-users-info
branch
from
187b506 to
8ff8465
Compare
sampaiodiego
added a commit
that referenced
this pull request
Feb 20, 2020
… exist (#16495) * Prevent user to be undefined * Move findById to Base model Co-authored-by: Diego Sampaio <[email protected]>
Merged
sampaiodiego
added a commit
that referenced
this pull request
Feb 20, 2020
… exist (#16495) * Prevent user to be undefined * Move findById to Base model Co-authored-by: Diego Sampaio <[email protected]>
sampaiodiego
added a commit
that referenced
this pull request
Feb 21, 2020
… exist (#16495) * Prevent user to be undefined * Move findById to Base model Co-authored-by: Diego Sampaio <[email protected]>
gabriellsh
added a commit
that referenced
this pull request
Feb 21, 2020
…use_scrollableArea * 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits) [FIX] ie11 support (#16682) Regression: Show upload errors (#16681) [FIX] Delete messages while searching bug (#16568) Use insertSync [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (#16416) [FIX] Added an option to pin/unpin a thread message by admin (#16457) [CHORE] Look for Storybook stories on `app/` too (#16595) [IMPROVE] Removed the 'reply in thread' from thread replies (#16630) [FIX] Changed Opt_In message (#16631) [FIX] LDAP sync admin action was not syncing exisent users (#16671) [IMPROVE] Check agent status when starting a new conversation with an agent assigned (#16618) [FIX] Additional scroll when contextual bar is open (#16667) [FIX] Clear unread red line when the ESC key is pressed (#16668) [FIX] users.info endpoint not handling the error if the user does not exist (#16495) [NEW] Save default filters in the Omnichannel Current Chats list (#16653) Update app/utils/client/lib/RestApiClient.js Update app/utils/client/lib/RestApiClient.js send files over rest api [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot Improved isSingular function ...
gabriellsh
added a commit
to subham103/Rocket.Chat
that referenced
this pull request
Feb 21, 2020
…6680-subham103-fixMessageCountStatistics * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] ie11 support (RocketChat#16682) Regression: Show upload errors (RocketChat#16681) [FIX] Delete messages while searching bug (RocketChat#16568) Use insertSync [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (RocketChat#16416) [FIX] Added an option to pin/unpin a thread message by admin (RocketChat#16457) [CHORE] Look for Storybook stories on `app/` too (RocketChat#16595) [IMPROVE] Removed the 'reply in thread' from thread replies (RocketChat#16630) [FIX] Changed Opt_In message (RocketChat#16631) [FIX] LDAP sync admin action was not syncing exisent users (RocketChat#16671) [IMPROVE] Check agent status when starting a new conversation with an agent assigned (RocketChat#16618) [FIX] Additional scroll when contextual bar is open (RocketChat#16667) [FIX] Clear unread red line when the ESC key is pressed (RocketChat#16668) [FIX] users.info endpoint not handling the error if the user does not exist (RocketChat#16495) Update app/utils/client/lib/RestApiClient.js Update app/utils/client/lib/RestApiClient.js send files over rest api [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot Improved isSingular function Add message_pruned and file_pruned for singular file or message deleted ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16491