[IMPROVE] Prevent "App user" from being deleted by the admin#16373
Merged
sampaiodiego merged 5 commits intodevelopfrom Jan 30, 2020
Merged
Conversation
sampaiodiego
requested changes
Jan 30, 2020
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
Please start error codes with error- =)
Co-Authored-By: Diego Sampaio <[email protected]>
Co-Authored-By: Diego Sampaio <[email protected]>
Co-Authored-By: Diego Sampaio <[email protected]>
Contributor
Author
|
@sampaiodiego Thanks! |
sampaiodiego
approved these changes
Jan 30, 2020
sampaiodiego
deleted the
app-user.prevent-app-users-from-being-deleted-by-admin
branch
ggazzo
added a commit
that referenced
this pull request
Jan 30, 2020
…it.2.0-turbo * 'develop' of github.com:RocketChat/Rocket.Chat: [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253) [FIX] The "click to load" text is hard-coded and not translated. (#16142)
gabriellsh
added a commit
that referenced
this pull request
Jan 31, 2020
…email-validation-message * 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits) [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378) [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253) [FIX] The "click to load" text is hard-coded and not translated. (#16142) ...
gabriellsh
added a commit
that referenced
this pull request
Jan 31, 2020
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378) [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253)
ggazzo
added a commit
that referenced
this pull request
Jan 31, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Container heights (#16388) Regression: App deletion wasn’t returning the correct information (#16360) [BREAK] Remove deprecated publications (#16351) [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378) [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356)
gabriellsh
added a commit
that referenced
this pull request
Feb 3, 2020
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: (46 commits) Regression: Fix status bar margins (#16438) [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) Fix index creation for apps_logs collection (#16401) Revert message properties validation (#16395) [FIX] Rooms not being marked as read sometimes (#16397) Update apps engine to 1.12.0-beta.2496 (#16398) [FIX] Container heights (#16388) Regression: App deletion wasn’t returning the correct information (#16360) [BREAK] Remove deprecated publications (#16351) [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378) [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) ...
ggazzo
added a commit
that referenced
this pull request
Feb 3, 2020
…nto system-messages * 'system-messages' of github.com:RocketChat/Rocket.Chat: [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent deleting an app user from the admin - users panel unexpectedly, which can make sure the app user is removed only through the corresponding app uninstallation.