[BREAK] Filter System messages per room#16369
Merged
sampaiodiego merged 41 commits intodevelopfrom Feb 4, 2020
Merged
Conversation
…-system-messages * 'develop' of github.com:RocketChat/Rocket.Chat: Changed Help wanted section (#16197)
…hat into hide-system-messages * 'hide-system-messages' of github.com:RocketChat/Rocket.Chat: fix lint MultiSelect using Fuselage
…-system-messages* 'develop' of github.com:RocketChat/Rocket.Chat: Add a converter on getting the file buffer from Apps-Engine. [FIX] Integrations admin page (#16183)
…hat into hide-system-messages
…hat into hide-system-messages * 'hide-system-messages' of github.com:RocketChat/Rocket.Chat: [FIX] Setup Wizard inputs and Admin Settings (#16147) revert changes Add a converter on getting the file buffer from Apps-Engine. [FIX] Integrations admin page (#16183) adding functions and code refactoring renamed multiSelect fix lint MultiSelect using Fuselage Changed Help wanted section (#16197)
…hat into hide-system-messages * 'hide-system-messages' of github.com:RocketChat/Rocket.Chat: revert highlight
…em-messages * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253) [FIX] The "click to load" text is hard-coded and not translated. (#16142) [FIX] Integrations list without pagination and outgoing integration creation (#16233)
…-system-messages * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253) [FIX] The "click to load" text is hard-coded and not translated. (#16142) [FIX] Integrations list without pagination and outgoing integration creation (#16233)
ggazzo
requested review from
diegolmello and
sampaiodiego
and removed request for
diegolmello
ggazzo
added
the
area: ui/ux
sampaiodiego
changed the title
rodrigok
requested changes
Feb 3, 2020
Member
rodrigok
left a comment
rodrigok
left a comment
There was a problem hiding this comment.
Topic and announcement changes are not available to hide.
app/channel-settings/server/functions/saveRoomSystemMessages.js
Outdated
Show resolved
Hide resolved
…nto system-messages * 'system-messages' of github.com:RocketChat/Rocket.Chat: [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352)
rodrigok
requested changes
Feb 3, 2020
app/channel-settings/server/functions/saveRoomSystemMessages.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: Rodrigo Nascimento <[email protected]>
…nto system-messages * 'system-messages' of github.com:RocketChat/Rocket.Chat: Update app/channel-settings/server/functions/saveRoomSystemMessages.js
rodrigok
requested changes
Feb 3, 2020
| function: 'RocketChat.saveRoomSystemMessages', | ||
| }); | ||
| } | ||
| if (systemMessages && (!Match.test(systemMessages, [String]) || systemMessages.some((value) => !MessageTypesValues.includes(value)))) { |
Member
There was a problem hiding this comment.
MessageTypesValues is an array of objects, the includes will not work
rodrigok
approved these changes
Feb 4, 2020
gabriellsh
added a commit
that referenced
this pull request
Feb 5, 2020
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits) [FIX] Missing edited icon in newly created messages (#16484) Regression: allow private channels to hide system messages (#16483) Regression: Fix uikit modal closing on click (#16475) Regression: Fix undefined presence after reconnect (#16477) [FIX] Read Message after receive a message and the room is opened (#16473) [FIX] Send message with pending messages (#16474) Fix tests (#16469) Bump version to 3.0.0-develop [NEW] Button to download admin server info (#16059) Revert importer streamed uploads (#16465) [NEW] UiKit - Interactive UI elements for Rocket.Chat Apps (#16048) [FIX] Result of get avatar from url can be null (#16123) [IMPROVE] Request user presence on demand (#16348) [IMPROVE] Major overhaul on data importers (#16279) [BREAK] Filter System messages per room (#16369) Regression: Fix app user status change for non-existing user (#16458) [FIX] `stdout` streamer infinite loop (#16452) Regression: Fix sending a message not scrolling to bottom (#16451) LingoHub based on develop (#16450) [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392) ...
Merged
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the room's owner can choose which system messages will be filtered overwriting the server config