Skip to content

[NEW] Translation via MS translate#16363

Merged
rodrigok merged 11 commits intoRocketChat:developfrom
assistify:core/feature/ms-translate
Mar 13, 2020
Merged

[NEW] Translation via MS translate#16363
rodrigok merged 11 commits intoRocketChat:developfrom
assistify:core/feature/ms-translate

Conversation

@mrsimpson
Copy link
Copy Markdown
Contributor

@mrsimpson mrsimpson commented Jan 28, 2020

Adds Microsoft's translation service (https://translator.microsoft.com/) as a provider for translation of messages.
In addition to implementing the interface (similar to google and DeepL), a small change has been done in order to display the translation provider on the UI.

@mrsimpson mrsimpson force-pushed the core/feature/ms-translate branch from 25caa13 to 571be13 Compare January 30, 2020 10:39
@ggazzo ggazzo requested a review from d-gubert January 30, 2020 20:33
@engelgabriel engelgabriel added this to the 3.1.0 milestone Mar 6, 2020
@rodrigok rodrigok changed the title Translation via MS translate [NEW] Translation via MS translate Mar 11, 2020
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mrsimpson
Copy link
Copy Markdown
Contributor Author

@rodrigok I updated the code as per all comments.
Manually tested:

  • Translating messages (en -> de, de -> en)
  • Translating attachment descriptions
  • Multi-Languages in mutliple lines
  • Error handling when entering a wrong key

@rodrigok
Copy link
Copy Markdown
Member

@mrsimpson almost perfect :)

@mrsimpson
Copy link
Copy Markdown
Contributor Author

@rodrigok I merged the latest develop and then checked out the package-lock.json.

@rodrigok rodrigok merged commit 6914d11 into RocketChat:develop Mar 13, 2020
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
@mrsimpson mrsimpson deleted the core/feature/ms-translate branch December 7, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants