[FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button#16215
Merged
ggazzo merged 5 commits intoRocketChat:developfrom Apr 14, 2020
ashwaniYDV:customsound
Merged
[FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button#16215ggazzo merged 5 commits intoRocketChat:developfrom ashwaniYDV:customsound
ggazzo merged 5 commits intoRocketChat:developfrom
ashwaniYDV:customsound
Conversation
Contributor
Author
|
@sampaiodiego @tassoevan Would you please review :) |
ashwaniYDV
changed the title
ashwaniYDV
changed the title
Member
|
Hey! Really cool what you did, works better in my opinion. Just make it so when the sound finishes playing it on its own resets to the play button. |
Contributor
Author
@gabriellsh I have done the requested changes. But doing so I encountered some more corner case issues. I have solved them too. |
gabriellsh
requested changes
Jan 29, 2020
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
You could just add this block inside the play event.
document.getElementById(this._id).onended = function() { t.isPlayingId.set(''); this.onended = null; };
Then you don't have to work with settimeout and the process is straightforward.
Obs.: don't forget to remove the event once the audio is stopped.
Contributor
Author
|
@gabriellsh Thank you very much. This reduced lots of code and also I don't have to worry about end cases which I faced using the settimeout. 👍 |
ashwaniYDV
changed the title
|
|
gabriellsh
added a commit
that referenced
this pull request
Apr 14, 2020
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) [FIX] translation for nl (#16742) [FIX] No maxlength defined for custom user status (#16534) [FIX] Directory users email sort button (#16606) [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405) [FIX] Email not verified message (#16236) [FIX] Directory default tab (#17283) Update ru.i18n.json (#16869) [FIX] Avatar on sidebar when showing real names (#17286) Update Apps-Engine to stable version (#17287) [NEW][ENTERPRISE] Auto close abandoned Omnichannel rooms (#17055) Static props for Administration route components (#17285) [NEW] Default favorite channels (#16025) Apply $and helper to message template (#17280)
gabriellsh
added a commit
that referenced
this pull request
Apr 15, 2020
…mailer * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) [FIX] translation for nl (#16742) [FIX] No maxlength defined for custom user status (#16534) [FIX] Directory users email sort button (#16606) [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405) [FIX] Email not verified message (#16236) [FIX] Directory default tab (#17283) Update ru.i18n.json (#16869) ...
ggazzo
added a commit
that referenced
this pull request
Apr 15, 2020
…dm/mailer * 'adm/mailer' of github.com:RocketChat/Rocket.Chat: (79 commits) removed unecessary prop Fixed sendMail function Removed Log, Success message Permissions added route component [FIX] "Invalid Invite" message when registration is disabled (#17226) Added route, error handling. [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) ...
dudizilla
added a commit
that referenced
this pull request
Apr 21, 2020
…nto view-logs * 'develop' of https://github.com/RocketChat/Rocket.Chat: (31 commits) Fixed componentes width (#17322) [IMPROVE] Administration -> Mailer Rewrite to React. (#17191) Regression: Storybook added flowrouter group mock (#17321) [NEW] Feature/custom oauth mail field and interpolation for mapped fields (#15690) [FIX] "Invalid Invite" message when registration is disabled (#17226) [FIX] Red color error outline is not removed after password update (#16536) [FIX] Change wording to start DM from info panel (#8799) New hooks for RouterContext (#17305) [FIX] SAML assertion signature enforcement (#17278) [FIX] LDAP users lose session on refresh (#17302) [NEW] Add MMS support to Voxtelesys (#17217) [FIX] Popover component doesn't have scroll (#17198) [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288) [FIX] User search on directory not working correctly (#17299) [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313) [FIX] Variable rendering problem on Import recent history page (#15997) [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215) [FIX] Discussions created from inside DMs were not working (#17282) [FIX] translation for nl (#16742) [FIX] No maxlength defined for custom user status (#16534) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16213 #16208
Before changes
(1) All sounds can be played simultaneously which overlaps with the other ones.
(2) There are seperate buttons for play and pause.
After changes:
(1) One sound can be played at a time.
(2) There is a single button for play and pause which looks consistent with most of the media players and is more handy for admins than having seperate buttons for play and pause.