[FIX] Pinned messages wouldn't collapse#16188
Merged
Conversation
ggazzo
added
the
area: ui/ux
MartinSchoeler
requested changes
Jan 14, 2020
Member
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
When I enable the user preference "Collapse Embedded Media by Default" I cannot open any attachments anymore.
Member
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
This also breaks attachments created via URL, I cannot close them anymore
Member
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
With Document Previews (PDFs) If I collapse it I can't open it again
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] The "click to load" text is hard-coded and not translated. (#16142) [FIX] Integrations list without pagination and outgoing integration creation (#16233) [FIX] Setup Wizard inputs and Admin Settings (#16147) Add a converter on getting the file buffer from Apps-Engine. [FIX] Integrations admin page (#16183) Changed Help wanted section (#16197) [IMPROVE] Improve function to check if setting has changed (#16181) fix: remove empty custom fields perf: replace getCustomFields by REST fix: set new custom fields values for livechat chore: fix review feat(livechat): add validation for custom fields strong for Department in VisitorInfo Add GUI for customFields in Livechat Regression: Enable apps change properties of the sender on the message as before (#16189) [FIX] User stuck after reset password (#16184)
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378) [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253)
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) Fix index creation for apps_logs collection (#16401) Revert message properties validation (#16395) [FIX] Rooms not being marked as read sometimes (#16397) Update apps engine to 1.12.0-beta.2496 (#16398) [FIX] Container heights (#16388) Regression: App deletion wasn’t returning the correct information (#16360) [BREAK] Remove deprecated publications (#16351)
Contributor
|
@gabriellsh @MartinSchoeler Is #9282 also fixed by this PR? |
Member
Author
|
@ashwaniYDV Yes, thank you 😁 |
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] `stdout` streamer infinite loop (#16452) Regression: Fix sending a message not scrolling to bottom (#16451) LingoHub based on develop (#16450) [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392) [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446) Use GitHub Actions to store builds (#16443) [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437) Regression: recent opened rooms being marked as read (#16442) [FIX] Option to make a channel default (#16433) [NEW] Setting to only send plain text emails (#16065) fix group Regression: Fix status bar margins (#16438) fix group messages
MartinSchoeler
previously approved these changes
Feb 4, 2020
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: (90 commits) [FIX] livechat/rooms endpoint not working with big amount of livechats (#16623) [FIX] Regression: Jitsi on external window infinite loop (#16625) [FIX] UiKit not updating new actionIds received as responses from actions (#16624) Bump version to 3.1.0-develop Bump version to 3.0.0 Bump version to 3.0.0-rc.11 Fix enter behavior send file on enter Fix github actions accessing the github registry (#16521) Bump version to 3.0.0-rc.10 [FIX] Bug on starting Jitsi video calls , multiple messages (#16601) Bump version to 3.0.0-rc.9 Regression: fix read unread messages (#16562) Regression: UIKit update modal actions (#16570) fixed duplicated toastrs (#16578) Update Livechat widget dependency version to 1.3.1. (#16580) Update Apps-Engine version (#16584) [FIX] Error when successfully joining room by invite link (#16571) Add breaking notice regarding TLS (#16575) [FIX] Invite links proxy URLs not working when using CDN (#16581) ...
|
|
ggazzo
approved these changes
Mar 18, 2020
ggazzo
added a commit
to wreiske/Rocket.Chat
that referenced
this pull request
Mar 19, 2020
…4892-wreiske-user-status-bubbles * 'develop' of github.com:RocketChat/Rocket.Chat: (540 commits) [FIX] Show error message if password and confirm password not equal (RocketChat#16247) [FIX] Message quote button inside threads (RocketChat#16925) Fix wrong imported library meteor/tap:i18n lint [IMPROVE] User gets feedback when a message has been starred or unstarred (RocketChat#13860) [FIX] admin can sort users by email in directory view (RocketChat#15796) [FIX] Pinned messages wouldn't collapse (RocketChat#16188) [IMPROVE] Added border to page header. (RocketChat#16792) [FIX] Correct thread messages display in context bar. (RocketChat#16835) [FIX] Public channel cannot be acessed via URL when 'Allow Anonymous Read' is active (RocketChat#16914) Fixed Line break incorrectly being called apostrophe (RocketChat#16918) [IMPROVE] Context menu autofocus (RocketChat#16915) Improve room types usage (RocketChat#16753) [NEW] API `users.deactivateIdle` for mass-disabling of idle users (RocketChat#16849) [NEW] API to logout from other locations (RocketChat#16193) [IMPROVE] Add option to require authentication on user's shield endpoint (RocketChat#16845) [FIX] Custom OAuth Bug (RocketChat#16811) [FIX] Integrations page pagination (RocketChat#16838) reset package-lock to upstream Apply suggestions from code review ...
ggazzo
added a commit
that referenced
this pull request
Mar 20, 2020
…ultiple-users* 'develop' of github.com:RocketChat/Rocket.Chat: (53 commits) [FIX] Show error message if password and confirm password not equal (#16247) [FIX] Message quote button inside threads (#16925) Fix wrong imported library meteor/tap:i18n lint [IMPROVE] User gets feedback when a message has been starred or unstarred (#13860) [FIX] admin can sort users by email in directory view (#15796) [FIX] Pinned messages wouldn't collapse (#16188) [IMPROVE] Added border to page header. (#16792) [FIX] Correct thread messages display in context bar. (#16835) [FIX] Public channel cannot be acessed via URL when 'Allow Anonymous Read' is active (#16914) Fixed Line break incorrectly being called apostrophe (#16918) [IMPROVE] Context menu autofocus (#16915) Improve room types usage (#16753) [NEW] API `users.deactivateIdle` for mass-disabling of idle users (#16849) [NEW] API to logout from other locations (#16193) [IMPROVE] Add option to require authentication on user's shield endpoint (#16845) [FIX] Custom OAuth Bug (#16811) [FIX] Integrations page pagination (#16838) reset package-lock to upstream Apply suggestions from code review ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3977
Closes #9282
Closes #16424
Closes #16423
Moved the collapse state to the messageAttachment template.