Skip to content

[FIX] JS errors on Administration page#16139

Merged
ggazzo merged 1 commit intodevelopfrom
resolving-admin-message-errors
Jan 6, 2020
Merged

[FIX] JS errors on Administration page#16139
ggazzo merged 1 commit intodevelopfrom
resolving-admin-message-errors

Conversation

@dudizilla
Copy link
Copy Markdown
Contributor

@dudizilla dudizilla commented Jan 6, 2020

Resolving console errors Administration -> Message related to Skeleton (Received true for a non-boolean attribute animated) and validateDOMNesting (h1 cannot appear as a child of h1).

@tassoevan tassoevan added area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: bug labels Jan 6, 2020
@tassoevan tassoevan requested review from ggazzo and tassoevan January 6, 2020 16:45
@tassoevan tassoevan added this to the 2.4.1 milestone Jan 6, 2020
@ggazzo ggazzo changed the title [FIX] Resolving console errors Administration -> Message [FIX] Resolving console errors Administration Jan 6, 2020
@ggazzo ggazzo merged commit eae58fa into develop Jan 6, 2020
@ggazzo ggazzo deleted the resolving-admin-message-errors branch January 6, 2020 17:44
gabriellsh added a commit that referenced this pull request Jan 9, 2020
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits)
  fix space
  update on mongo, node and caddy
  [NEW] Enforce plain text emails converting from HTML when no text version supplied (#16063)
  [IMPROVE] Status Text form validation (#16121)
  [FIX] auto translate cache (#15768)
  [FIX] Save new password without confirmation (#16060)
  Disable PR Docker image build (#16141)
  [IMPROVE] Set the color of the cancel button on modals to #bdbebf for enhanced  visibiity (#15913)
  [FIX] Break message-attachment text to the next line (#16039)
  [IMPROVE] Remove NRR (#16071)
  Add Cloud Info to translation dictionary (#16122)
  [FIX] Resolving console errors Administrations (#16139)
  [FIX] SafePorts: Ports 80, 8080 & 443 linked to respective protocols (#16108)
  [FIX] Drag and drop disabled when file upload is disabled (#16049)
  [FIX] Video message sent to wrong room (#16113)
  [FIX] "User not found" for direct messages (#16047)
  [BREAK] Removed room counter from sidebar (#16036)
  [FIX] Embedded style when using 'go' command  (#16051)
  [NEW]  Setting Top navbar in embedded mode (#16064)
  [FIX] Thread message icon overlapping text (#16083)
  ...
@sampaiodiego sampaiodiego changed the title [FIX] Resolving console errors Administration [FIX] JS errors on Administration page Jan 10, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants