Skip to content

[FIX] Video message sent to wrong room#16113

Merged
ggazzo merged 3 commits intodevelopfrom
fix/video_sent_to_wrong_channel
Jan 6, 2020
Merged

[FIX] Video message sent to wrong room#16113
ggazzo merged 3 commits intodevelopfrom
fix/video_sent_to_wrong_channel

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

Closes #14872

When recording a video, if trying to record a new one on another room (direct, channel, group), sending the video would upload it to the first channel the video recorder rendered.
Changed data to reactive vars and moved some code to a more appropriate place.

@ggazzo ggazzo added this to the 3.0.0 milestone Jan 6, 2020
@ggazzo ggazzo added the area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction label Jan 6, 2020
@ggazzo ggazzo merged commit c99a749 into develop Jan 6, 2020
@ggazzo ggazzo deleted the fix/video_sent_to_wrong_channel branch January 6, 2020 12:11
gabriellsh added a commit that referenced this pull request Jan 9, 2020
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits)
  fix space
  update on mongo, node and caddy
  [NEW] Enforce plain text emails converting from HTML when no text version supplied (#16063)
  [IMPROVE] Status Text form validation (#16121)
  [FIX] auto translate cache (#15768)
  [FIX] Save new password without confirmation (#16060)
  Disable PR Docker image build (#16141)
  [IMPROVE] Set the color of the cancel button on modals to #bdbebf for enhanced  visibiity (#15913)
  [FIX] Break message-attachment text to the next line (#16039)
  [IMPROVE] Remove NRR (#16071)
  Add Cloud Info to translation dictionary (#16122)
  [FIX] Resolving console errors Administrations (#16139)
  [FIX] SafePorts: Ports 80, 8080 & 443 linked to respective protocols (#16108)
  [FIX] Drag and drop disabled when file upload is disabled (#16049)
  [FIX] Video message sent to wrong room (#16113)
  [FIX] "User not found" for direct messages (#16047)
  [BREAK] Removed room counter from sidebar (#16036)
  [FIX] Embedded style when using 'go' command  (#16051)
  [NEW]  Setting Top navbar in embedded mode (#16064)
  [FIX] Thread message icon overlapping text (#16083)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video message sent into wrong channel if recording was canceled before

2 participants