Skip to content

[FIX] Save password without confirmation#16060

Merged
ggazzo merged 1 commit intoRocketChat:developfrom
ashwaniYDV:profilepwdissue
Jan 8, 2020
Merged

[FIX] Save password without confirmation#16060
ggazzo merged 1 commit intoRocketChat:developfrom
ashwaniYDV:profilepwdissue

Conversation

@ashwaniYDV
Copy link
Copy Markdown
Contributor

@ashwaniYDV ashwaniYDV commented Dec 24, 2019

Closes #16057

Before changes (gif)

User can click "Save Profile and thus can update password"
11

After changes (gif)

The "Save Profile" button is disabled if password is not equal to confirm-password
22

@ashwaniYDV ashwaniYDV changed the title User Profile button disabled if password and confirm passwrod are not… User Profile button disabled if pwd and confirm-pwd are different Dec 24, 2019
@ashwaniYDV ashwaniYDV changed the title User Profile button disabled if pwd and confirm-pwd are different User Save Profile button disabled if pwd and confirm-pwd are different Dec 28, 2019
@ashwaniYDV
Copy link
Copy Markdown
Contributor Author

@sampaiodiego Please review.

@ggazzo ggazzo added this to the 3.0.0 milestone Jan 8, 2020
@ggazzo ggazzo changed the title User Save Profile button disabled if pwd and confirm-pwd are different [FIX] Save password without confirmation Jan 8, 2020
@ggazzo ggazzo merged commit 5153115 into RocketChat:develop Jan 8, 2020
gabriellsh added a commit that referenced this pull request Jan 9, 2020
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits)
  fix space
  update on mongo, node and caddy
  [NEW] Enforce plain text emails converting from HTML when no text version supplied (#16063)
  [IMPROVE] Status Text form validation (#16121)
  [FIX] auto translate cache (#15768)
  [FIX] Save new password without confirmation (#16060)
  Disable PR Docker image build (#16141)
  [IMPROVE] Set the color of the cancel button on modals to #bdbebf for enhanced  visibiity (#15913)
  [FIX] Break message-attachment text to the next line (#16039)
  [IMPROVE] Remove NRR (#16071)
  Add Cloud Info to translation dictionary (#16122)
  [FIX] Resolving console errors Administrations (#16139)
  [FIX] SafePorts: Ports 80, 8080 & 443 linked to respective protocols (#16108)
  [FIX] Drag and drop disabled when file upload is disabled (#16049)
  [FIX] Video message sent to wrong room (#16113)
  [FIX] "User not found" for direct messages (#16047)
  [BREAK] Removed room counter from sidebar (#16036)
  [FIX] Embedded style when using 'go' command  (#16051)
  [NEW]  Setting Top navbar in embedded mode (#16064)
  [FIX] Thread message icon overlapping text (#16083)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password is updated even if the password and confirm password are not equal

2 participants