Skip to content

[NEW] Default favorite channels#16025

Merged
ggazzo merged 26 commits intodevelopfrom
new/default-favorite-channels
Apr 13, 2020
Merged

[NEW] Default favorite channels#16025
ggazzo merged 26 commits intodevelopfrom
new/default-favorite-channels

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh commented Dec 19, 2019

Closes #6929
Closes #7007

Added a new setting inside the "Default" channel option.
It's called "Set as favorite", will only show up when the channel is set to be default. Channels with the setting checked will automatically be added as favourite when the user is created.

image

image

ggazzo
ggazzo previously requested changes Dec 20, 2019
Copy link
Copy Markdown
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the conflict and pay attention to do not insert console.log even commented

…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits)
  [IMPROVE] Notify logged agents when their departments change (#16033)
  [IMPROVE] Replace fullEmojiData publication by REST (#15901)
  [IMPROVE] Replace adminRooms publication by REST (#15948)
  [IMPROVE] Replace webdavAccounts publication by REST (#15926)
  [IMPROVE] Replace oauth publications by REST (#15878)
  [IMPROVE] Replace userAutocomplete publication by REST (#15956)
  [IMPROVE] Replace discussionsOfARoom publication by REST (#15908)
  [FIX] width of upload-progress-text (#16023)
  corrected Grammatical errors (#15570)
  Upgrade limax to 2.0.0 (#16020)
  [IMPROVE] Replace customSounds publication by REST (#15907)
  [FIX] Message list scrolling to bottom on reactions (#16018)
  [IMPROVE] Replace stdout publication by REST (#16004)
  [FIX] SAML logout error (#15978)
  [FIX] Added Join button to Read Only rooms. (#16016)
  [IMPROVE] Replace fullUserStatusData publication by REST (#15942)
  [IMPROVE] Replace userData subscriptions by REST (#15916)
  [FIX] z-index of new message button (#16013)
  [FIX] new message popup (#16017)
  [FIX] Changed renderMessage priority, fixed Katex on/off setting (#16012)
  ...
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Change version to 2.4.0
  Update NodeJS to 8.17.0 (#16043)
  [NEW] Invite links: share a link to invite users (#15933)
  Fix typo in Italian translation (#15998)
  Update Meteor 1.8.3 (#16037)
  [FIX] Importer: Variable name appearing instead of it's value (#16010)
  [IMPROVE] Replace livechat:inquiry publication by REST and Streamer (#15977)
  [IMPROVE] Sorting on livechat analytics queries were wrong (#16021)
  [IMPROVE] Replace fullUserData publication by REST (#15650)
  [IMPROVE] Replace integrations and integrationHistory publications by REST (#15885)
  Some performance improvements (#15886)
  [FIX]Add time format for latest message on the sidebar (#15930)
  [FIX] Admin Setting descriptions and Storybook (#15994)
  Bump version to 2.3.2
  [FIX] Invalid Redirect URI on Custom OAuth (#15957)
  [NEW] Livechat Widget version 1.3.0 (#15966)
MartinSchoeler
MartinSchoeler previously approved these changes Dec 23, 2019
Copy link
Copy Markdown
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check the comments ;)

…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Update components (#16053)
Copy link
Copy Markdown
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comments below, and please rename defaultFavorite to favorite

gabriellsh and others added 4 commits January 8, 2020 09:05
Co-Authored-By: Guilherme Gazzo <[email protected]>
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (31 commits)
  fix space
  update on mongo, node and caddy
  [NEW] Enforce plain text emails converting from HTML when no text version supplied (#16063)
  [IMPROVE] Status Text form validation (#16121)
  [FIX] auto translate cache (#15768)
  [FIX] Save new password without confirmation (#16060)
  Disable PR Docker image build (#16141)
  [IMPROVE] Set the color of the cancel button on modals to #bdbebf for enhanced  visibiity (#15913)
  [FIX] Break message-attachment text to the next line (#16039)
  [IMPROVE] Remove NRR (#16071)
  Add Cloud Info to translation dictionary (#16122)
  [FIX] Resolving console errors Administrations (#16139)
  [FIX] SafePorts: Ports 80, 8080 & 443 linked to respective protocols (#16108)
  [FIX] Drag and drop disabled when file upload is disabled (#16049)
  [FIX] Video message sent to wrong room (#16113)
  [FIX] "User not found" for direct messages (#16047)
  [BREAK] Removed room counter from sidebar (#16036)
  [FIX] Embedded style when using 'go' command  (#16051)
  [NEW]  Setting Top navbar in embedded mode (#16064)
  [FIX] Thread message icon overlapping text (#16083)
  ...
…/Rocket.Chat into new/default-favorite-channels

* 'new/default-favorite-channels' of github.com:RocketChat/Rocket.Chat:
  whitespace
@ggazzo ggazzo added this to the 3.0.0 milestone Jan 14, 2020
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (46 commits)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  ...
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Setting to only send plain text emails (#16065)
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits)
  [FIX] Missing edited icon in newly created messages (#16484)
  Regression: allow private channels to hide system messages  (#16483)
  Regression: Fix uikit modal closing on click (#16475)
  Regression: Fix undefined presence after reconnect (#16477)
  [FIX] Read Message after receive a message and the room is opened (#16473)
  [FIX] Send message with pending messages (#16474)
  Fix tests (#16469)
  Bump version to 3.0.0-develop
  [NEW] Button to download admin server info (#16059)
  Revert importer streamed uploads (#16465)
  [NEW] UiKit - Interactive UI elements for Rocket.Chat Apps (#16048)
  [FIX] Result of get avatar from url can be null (#16123)
  [IMPROVE] Request user presence on demand (#16348)
  [IMPROVE] Major overhaul on data importers (#16279)
  [BREAK] Filter System messages per room (#16369)
  Regression: Fix app user status change for non-existing user (#16458)
  [FIX] `stdout` streamer infinite loop (#16452)
  Regression: Fix sending a message not scrolling to bottom (#16451)
  LingoHub based on develop (#16450)
  [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392)
  ...
@engelgabriel engelgabriel modified the milestones: 3.0.0, 3.1.0 Mar 17, 2020
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

gabriellsh and others added 4 commits April 2, 2020 18:08
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (304 commits)
  [FIX] Omnichannel endpoint `inquiries.getOne` returning only queued inquiries (#17132)
  Fix design review (#17133)
  Regression: Direct message creation by REST (#17109)
  Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128)
  Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127)
  Regression: IE11 Support (#17125)
  [FIX] Federation delete room event not being dispatched (#16861)
  [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878)
  New Troubleshoot section for disabling features (#17114)
  Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118)
  [NEW] Discussions: Inherit the public status of parent channel (#17070)
  Regression: fix fuselage import, remove directory css (#17116)
  [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115)
  Regression: Remove old and closed Omnichannel inquiries (#17113)
  [FIX] Member's list only filtering users already on screen (#17110)
  Single codebase announcement (#17081)
  [NEW] Directory page refactored, new user's bio field (#17043)
  [NEW] Sort List, View Mode and Group by revamp (#17103)
  Regression: Files were been deleted when deleting users as last members of private rooms (#17111)
  Regression: Block users was not possible for 1:1 DMs (#17105)
  ...
…/Rocket.Chat into new/default-favorite-channels

* 'new/default-favorite-channels' of github.com:RocketChat/Rocket.Chat:
@ggazzo ggazzo modified the milestones: 3.1.0, 3.2.0 Apr 13, 2020
@ggazzo ggazzo merged commit 16628f7 into develop Apr 13, 2020
@ggazzo ggazzo deleted the new/default-favorite-channels branch April 13, 2020 20:15
gabriellsh added a commit that referenced this pull request Apr 14, 2020
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  [FIX] translation for nl (#16742)
  [FIX] No maxlength defined for custom user status (#16534)
  [FIX] Directory users email sort button (#16606)
  [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405)
  [FIX] Email not verified message (#16236)
  [FIX] Directory default tab (#17283)
  Update ru.i18n.json (#16869)
  [FIX] Avatar on sidebar when showing real names (#17286)
  Update Apps-Engine to stable version (#17287)
  [NEW][ENTERPRISE] Auto close abandoned Omnichannel rooms (#17055)
  Static props for Administration route components (#17285)
  [NEW] Default favorite channels (#16025)
  Apply $and helper to message template (#17280)
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't set default rooms anymore Pre-set a channel or user to be a favority for all users?

5 participants