Skip to content

[FIX]Added Join button to Read Only rooms.#16016

Merged
ggazzo merged 4 commits intodevelopfrom
fix/users-cannot-join-readonly-room
Dec 19, 2019
Merged

[FIX]Added Join button to Read Only rooms.#16016
ggazzo merged 4 commits intodevelopfrom
fix/users-cannot-join-readonly-room

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

Closes #14910

The "Join" button wasn't showing up in read only rooms, making it impossible for users to read messages in some cases.

@MartinSchoeler MartinSchoeler changed the base branch from develop to master December 18, 2019 19:07
@MartinSchoeler MartinSchoeler changed the base branch from master to develop December 18, 2019 19:07
@ggazzo ggazzo merged commit 79c2c44 into develop Dec 19, 2019
@ggazzo ggazzo deleted the fix/users-cannot-join-readonly-room branch December 19, 2019 01:02
@ggazzo ggazzo added this to the 3.0.0 milestone Dec 19, 2019
@ggazzo ggazzo added the area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction label Dec 19, 2019
dudizilla added a commit that referenced this pull request Dec 19, 2019
…scroll

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Added Join button to Read Only rooms. (#16016)
  [IMPROVE] Replace fullUserStatusData publication by REST (#15942)
  [IMPROVE] Replace userData subscriptions by REST (#15916)
  [FIX] z-index of new message button (#16013)
  [FIX] new message popup (#16017)
  [FIX] Changed renderMessage priority, fixed Katex on/off setting (#16012)
  [FIX] Empty security section when 2fa is disabled (#16009)
  [FIX] Dropzone being stuck when dragging to thread (#16006)
gabriellsh added a commit that referenced this pull request Dec 23, 2019
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits)
  [IMPROVE] Notify logged agents when their departments change (#16033)
  [IMPROVE] Replace fullEmojiData publication by REST (#15901)
  [IMPROVE] Replace adminRooms publication by REST (#15948)
  [IMPROVE] Replace webdavAccounts publication by REST (#15926)
  [IMPROVE] Replace oauth publications by REST (#15878)
  [IMPROVE] Replace userAutocomplete publication by REST (#15956)
  [IMPROVE] Replace discussionsOfARoom publication by REST (#15908)
  [FIX] width of upload-progress-text (#16023)
  corrected Grammatical errors (#15570)
  Upgrade limax to 2.0.0 (#16020)
  [IMPROVE] Replace customSounds publication by REST (#15907)
  [FIX] Message list scrolling to bottom on reactions (#16018)
  [IMPROVE] Replace stdout publication by REST (#16004)
  [FIX] SAML logout error (#15978)
  [FIX] Added Join button to Read Only rooms. (#16016)
  [IMPROVE] Replace fullUserStatusData publication by REST (#15942)
  [IMPROVE] Replace userData subscriptions by REST (#15916)
  [FIX] z-index of new message button (#16013)
  [FIX] new message popup (#16017)
  [FIX] Changed renderMessage priority, fixed Katex on/off setting (#16012)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Dec 26, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Users cannot join readonly room

3 participants