[FIX] Importer: Variable name appearing instead of it's value#16010
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Dec 22, 2019
ashwaniYDV:issue1
Merged
[FIX] Importer: Variable name appearing instead of it's value#16010rodrigok merged 2 commits intoRocketChat:developfrom ashwaniYDV:issue1
rodrigok merged 2 commits intoRocketChat:developfrom
ashwaniYDV:issue1
Conversation
ashwaniYDV
changed the title
ashwaniYDV
changed the title
Member
|
@ashwaniYDV thanks for your contribution. Would be better to execute the translation on the client side (the template file) where we loop for those importes and print their names. That would prevent new importers to miss the translation method. Could even add the other descriptions to our en.i18n.json file to be translated as well. Are you ok to do these changes? |
ggazzo
previously approved these changes
Dec 19, 2019
Contributor
Author
rodrigok
approved these changes
Dec 22, 2019
rodrigok
changed the title
Member
|
Thanks @ashwaniYDV |
gabriellsh
added a commit
that referenced
this pull request
Dec 23, 2019
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: Change version to 2.4.0 Update NodeJS to 8.17.0 (#16043) [NEW] Invite links: share a link to invite users (#15933) Fix typo in Italian translation (#15998) Update Meteor 1.8.3 (#16037) [FIX] Importer: Variable name appearing instead of it's value (#16010) [IMPROVE] Replace livechat:inquiry publication by REST and Streamer (#15977) [IMPROVE] Sorting on livechat analytics queries were wrong (#16021) [IMPROVE] Replace fullUserData publication by REST (#15650) [IMPROVE] Replace integrations and integrationHistory publications by REST (#15885) Some performance improvements (#15886) [FIX]Add time format for latest message on the sidebar (#15930) [FIX] Admin Setting descriptions and Storybook (#15994) Bump version to 2.3.2 [FIX] Invalid Redirect URI on Custom OAuth (#15957) [NEW] Livechat Widget version 1.3.0 (#15966)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15981
Before change
After change