Skip to content

[FIX] SAML logout error#15978

Merged
sampaiodiego merged 5 commits intodevelopfrom
fix-saml-error-on-logout
Dec 19, 2019
Merged

[FIX] SAML logout error#15978
sampaiodiego merged 5 commits intodevelopfrom
fix-saml-error-on-logout

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego commented Dec 13, 2019

If SAML is turned on but an user logs out without logging in with SAML before, Rocket.Chat will throw the following error:

I20191212-12:50:08.442(-3)? Exception while invoking method 'samlLogout' TypeError: Cannot read property 'services' of undefined
I20191212-12:50:08.443(-3)?     at MethodInvocation.samlLogout (app/meteor-accounts-saml/server/saml_server.js:64:25)
I20191212-12:50:08.443(-3)?     at MethodInvocation.methodsMap.(anonymous function) (app/lib/server/lib/debug.js:67:34)
I20191212-12:50:08.444(-3)?     at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12)
I20191212-12:50:08.445(-3)?     at DDP._CurrentMethodInvocation.withValue (packages/ddp-server/livedata_server.js:719:19)
I20191212-12:50:08.503(-3)?     at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
I20191212-12:50:08.503(-3)?     at DDPServer._CurrentWriteFence.withValue (packages/ddp-server/livedata_server.js:717:46)
I20191212-12:50:08.504(-3)?     at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
I20191212-12:50:08.504(-3)?     at Promise (packages/ddp-server/livedata_server.js:715:46)
I20191212-12:50:08.504(-3)?     at new Promise (<anonymous>)
I20191212-12:50:08.504(-3)?     at Session.method (packages/ddp-server/livedata_server.js:689:23)
I20191212-12:50:08.504(-3)?     at packages/ddp-server/livedata_server.js:559:43

@sampaiodiego sampaiodiego added this to the 3.0.0 milestone Dec 13, 2019
@rodrigok rodrigok self-assigned this Dec 16, 2019
rodrigok
rodrigok requested changes Dec 16, 2019
View reviewed changes
@sampaiodiego sampaiodiego merged commit a632a32 into develop Dec 19, 2019
@sampaiodiego sampaiodiego deleted the fix-saml-error-on-logout branch December 19, 2019 16:09
gabriellsh added a commit that referenced this pull request Dec 23, 2019
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
033357b 
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits)
  [IMPROVE] Notify logged agents when their departments change (#16033)
  [IMPROVE] Replace fullEmojiData publication by REST (#15901)
  [IMPROVE] Replace adminRooms publication by REST (#15948)
  [IMPROVE] Replace webdavAccounts publication by REST (#15926)
  [IMPROVE] Replace oauth publications by REST (#15878)
  [IMPROVE] Replace userAutocomplete publication by REST (#15956)
  [IMPROVE] Replace discussionsOfARoom publication by REST (#15908)
  [FIX] width of upload-progress-text (#16023)
  corrected Grammatical errors (#15570)
  Upgrade limax to 2.0.0 (#16020)
  [IMPROVE] Replace customSounds publication by REST (#15907)
  [FIX] Message list scrolling to bottom on reactions (#16018)
  [IMPROVE] Replace stdout publication by REST (#16004)
  [FIX] SAML logout error (#15978)
  [FIX] Added Join button to Read Only rooms. (#16016)
  [IMPROVE] Replace fullUserStatusData publication by REST (#15942)
  [IMPROVE] Replace userData subscriptions by REST (#15916)
  [FIX] z-index of new message button (#16013)
  [FIX] new message popup (#16017)
  [FIX] Changed renderMessage priority, fixed Katex on/off setting (#16012)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Dec 26, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees

@rodrigok rodrigok

Labels

None yet

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sampaiodiego @rodrigok