[NEW] Invite links: share a link to invite users#15933
Merged
Conversation
|
This pull request introduces 1 alert when merging fa56ae0 into 003e135 - view on LGTM.com new alerts:
|
rodrigok
reviewed
Dec 10, 2019
rodrigok
reviewed
Dec 10, 2019
rodrigok
reviewed
Dec 10, 2019
rodrigok
reviewed
Dec 10, 2019
rodrigok
reviewed
Dec 10, 2019
rodrigok
requested changes
Dec 10, 2019
rodrigok
reviewed
Dec 10, 2019
sampaiodiego
previously requested changes
Dec 10, 2019
Co-Authored-By: Rodrigo Nascimento <[email protected]>
rodrigok
reviewed
Dec 15, 2019
|
|
||
| const useDirectLink = settings.get('Accounts_Registration_InviteUrlType') === 'direct'; | ||
| // Remove the last dash if present | ||
| const siteUrl = settings.get('Site_Url').replace(/\/$/g, ''); |
Member
There was a problem hiding this comment.
Could use the getUrl method from here and create an extra option there redirectViaCloud that would populate the host param and will receive others via an object like redirectViCloudParams so we can reuse this logic.
rodrigok
requested changes
Dec 18, 2019
rodrigok
requested changes
Dec 18, 2019
rodrigok
requested changes
Dec 20, 2019
|
|
||
| const useDirectLink = settings.get('Accounts_Registration_InviteUrlType') === 'direct'; | ||
| // Remove the last dash if present | ||
| const siteUrl = settings.get('Site_Url').replace(/\/$/g, ''); |
|
|
||
| export const validateInviteToken = (token) => { | ||
| if (!token) { | ||
| throw new Meteor.Error('error-invalid-token', 'The invite token is invalid.', { method: 'validateInviteToken', field: 'token' }); |
Member
There was a problem hiding this comment.
Not sure, why no token is an exception and an invalid token is a false return? Aren't they all invalid?
I'd agree to never return false, always an exception or the {invite, room}.
Member
|
Can you translate to pt-BR as well? |
|
This pull request introduces 2 alerts when merging 31c5d60 into c558273 - view on LGTM.com new alerts:
|
rodrigok
reviewed
Dec 20, 2019
rodrigok
reviewed
Dec 20, 2019
rodrigok
reviewed
Dec 20, 2019
rodrigok
approved these changes
Dec 21, 2019
rodrigok
changed the title
gabriellsh
added a commit
that referenced
this pull request
Dec 23, 2019
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: Change version to 2.4.0 Update NodeJS to 8.17.0 (#16043) [NEW] Invite links: share a link to invite users (#15933) Fix typo in Italian translation (#15998) Update Meteor 1.8.3 (#16037) [FIX] Importer: Variable name appearing instead of it's value (#16010) [IMPROVE] Replace livechat:inquiry publication by REST and Streamer (#15977) [IMPROVE] Sorting on livechat analytics queries were wrong (#16021) [IMPROVE] Replace fullUserData publication by REST (#15650) [IMPROVE] Replace integrations and integrationHistory publications by REST (#15885) Some performance improvements (#15886) [FIX]Add time format for latest message on the sidebar (#15930) [FIX] Admin Setting descriptions and Storybook (#15994) Bump version to 2.3.2 [FIX] Invalid Redirect URI on Custom OAuth (#15957) [NEW] Livechat Widget version 1.3.0 (#15966)
8 tasks
Contributor
|
Hi, is there any documentation about this feature? How does it look like and how do I use this it? Are there any parameters configureable (e.g. the expiration time for the link)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE_NUMBER