[IMPROVE] Replace fullEmojiData publication by REST#15901
Merged
sampaiodiego merged 11 commits intodevelopfrom Dec 20, 2019
Merged
[IMPROVE] Replace fullEmojiData publication by REST#15901sampaiodiego merged 11 commits intodevelopfrom
sampaiodiego merged 11 commits intodevelopfrom
Conversation
|
|
sampaiodiego
requested changes
Dec 19, 2019
app/api/server/v1/emoji-custom.js
Outdated
| }, | ||
| }); | ||
|
|
||
| API.v1.addRoute('emoji-custom.listWithPagination', { authRequired: true }, { |
Member
There was a problem hiding this comment.
I didn't like the name of the endpoint 🙈 and also it doesn't follow any name convention we're using.. what do you think if we change it to emoji-custom.all ? we could even create a standard where all .all endpoint are paginated (even though I think all .list should be)
app/api/server/lib/emoji-custom.js
Outdated
| import { EmojiCustom } from '../../../models/server/raw'; | ||
|
|
||
| export async function findEmojisCustom({ query = {}, pagination: { offset, count, sort } }) { | ||
| const cursor = await EmojiCustom.find(query, { |
Member
There was a problem hiding this comment.
find doesn't return a promise.
Suggested change
| const cursor = await EmojiCustom.find(query, { | |
| const cursor = EmojiCustom.find(query, { |
sampaiodiego
approved these changes
Dec 20, 2019
gabriellsh
added a commit
that referenced
this pull request
Dec 23, 2019
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits) [IMPROVE] Notify logged agents when their departments change (#16033) [IMPROVE] Replace fullEmojiData publication by REST (#15901) [IMPROVE] Replace adminRooms publication by REST (#15948) [IMPROVE] Replace webdavAccounts publication by REST (#15926) [IMPROVE] Replace oauth publications by REST (#15878) [IMPROVE] Replace userAutocomplete publication by REST (#15956) [IMPROVE] Replace discussionsOfARoom publication by REST (#15908) [FIX] width of upload-progress-text (#16023) corrected Grammatical errors (#15570) Upgrade limax to 2.0.0 (#16020) [IMPROVE] Replace customSounds publication by REST (#15907) [FIX] Message list scrolling to bottom on reactions (#16018) [IMPROVE] Replace stdout publication by REST (#16004) [FIX] SAML logout error (#15978) [FIX] Added Join button to Read Only rooms. (#16016) [IMPROVE] Replace fullUserStatusData publication by REST (#15942) [IMPROVE] Replace userData subscriptions by REST (#15916) [FIX] z-index of new message button (#16013) [FIX] new message popup (#16017) [FIX] Changed renderMessage priority, fixed Katex on/off setting (#16012) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.