Closed
Conversation
Member
|
@sampaiodiego it will close #14946 right? |
Member
Author
|
yes @rodrigok .. thanks |
|
Am I understanding that you are pulling the custom sounds option and only linking them to desktop preferences? So the issues listed under #14946 will not be fixed and instead removed? |
Member
Author
|
right @FixitMad .. but since this change will be a breaking change, we decided to first fix the other issue first.. |
|
@sampaiodiego , Ahh ok. I was confused. Thanks for the update. |
# Conflicts: # app/lib/server/startup/settings.js # app/ui-account/client/accountPreferences.js # tests/pageobjects/administration.page.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14946
Remove audio preferences and make them tied to desktop notification preferences.
TL;DR: new message sounds will play only if you receive a desktop notification. you'll still be able to chose to not play any sound