Conversation
ggazzo
approved these changes
Oct 24, 2019
rodrigok
added a commit
that referenced
this pull request
Oct 24, 2019
…iptions-without-ls [FIX] Read Receipts were not working properly with subscriptions without ls
Merged
This was referenced Nov 22, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May be related to #15484 (comment)
The Read Receipts logic was getting the oldest
ls(last seen, field where we store the time the user read the subscription last time) for the channel, so if some user, like a bot, was in the channel without that property set yet, the result could beundefined. If that user never enter in the channel to receive his firstlsthe read receipts would stop working (the case for the bots)