[Apps] Move external components SDK's host logic into apps-engine#15618
Merged
d-gubert merged 7 commits intololimay-apps-engine-experimentalfrom Nov 11, 2019
Merged
[Apps] Move external components SDK's host logic into apps-engine#15618d-gubert merged 7 commits intololimay-apps-engine-experimentalfrom
d-gubert merged 7 commits intololimay-apps-engine-experimentalfrom
Conversation
shiqimei
changed the title
|
This pull request fixes 1 alert when merging 33a3eff into f9262d2 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 9dded2e into f9262d2 - view on LGTM.com fixed alerts:
|
…' into move-host-logic
|
This pull request fixes 1 alert when merging 8061c35 into 3a18bb8 - view on LGTM.com fixed alerts:
|
* Add externalComponentEvent listener * Add new API endpoint externalComponentEvent * trigger external component events when needed * Remove console.log * corrent external component events' name * fix typo☹️ * Fix typo 😤 * Create new endpoint groupMembers to fix rate limter * Update app/apps/server/communication/rest.js
|
This pull request fixes 1 alert when merging bf8a2b2 into 3a18bb8 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 71afe8c into e517bc9 - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to move external components SDK's host logic into apps-engine.
depends on: RocketChat/Rocket.Chat.Apps-engine#165