[FIX] Remove unique index from read receipt messageid #15601
Closed
geekgonecrazy wants to merge 1 commit intodevelopfrom
Closed
[FIX] Remove unique index from read receipt messageid #15601geekgonecrazy wants to merge 1 commit intodevelopfrom
geekgonecrazy wants to merge 1 commit intodevelopfrom
Conversation
Contributor
|
👀 😍 |
Contributor
Author
|
@MarcosSpessatto should we dropIndex in migration and then ensure again? Not sure best way to do this with the models |
Member
|
@geekgonecrazy I don't think this would solve the problem since the index added on the PR merged was not the one with the unique modifier. We need to investigate this better since the compound index is correct there. Only one read per message per user is allowed. |
Contributor
Author
|
ah right.. thats a compound index. mine is not valid then 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rocketchat/backend we might have to create a migration some how to recreate this index or to remove unique from messageId?
This would fix #15484