[IMPROVE] Add missing indices used by read receipts#15316
Merged
sampaiodiego merged 3 commits intodevelopfrom Sep 13, 2019
Merged
[IMPROVE] Add missing indices used by read receipts#15316sampaiodiego merged 3 commits intodevelopfrom
sampaiodiego merged 3 commits intodevelopfrom
Conversation
ggazzo
previously approved these changes
Sep 6, 2019
Contributor
|
I was just about to open an issue for this! The read receipts seem to take a really long time to load... I assume the new index helps the speed a bit? I was going to go digging but you beat me to it. This is how long it takes currently: |
Member
Author
|
I know for sure this indices helps on making rooms as read.. I can check if they help loading the list of users as well, or if there is missing index there too. thanks @wreiske |
ggazzo
previously approved these changes
Sep 13, 2019
ggazzo
approved these changes
Sep 13, 2019
Member
Author
|
@wreiske I've added an index that will help.. But there are other improvements to do to make that screen load faster 👍 |
Contributor
Awesome, thanks! I use the read receipt info multiple times a day. :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two missing indices on Subscriptions collection used by read receipts queries:
And another on on ReadReceipts collection used to see who read a message: