Apps engine.ui.extra component 1#15111
Merged
d-gubert merged 22 commits intoRocketChat:lolimay-apps-engine-experimentalfrom Aug 7, 2019
Merged
Apps engine.ui.extra component 1#15111d-gubert merged 22 commits intoRocketChat:lolimay-apps-engine-experimentalfrom
d-gubert merged 22 commits intoRocketChat:lolimay-apps-engine-experimentalfrom
Conversation
* in order to keep consistent with gameCenter.html
d-gubert
changed the base branch from
develop
to
lolimay-apps-engine-experimental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I added the following changes:
Game Center
In order to present all the games in a place, I created a tab bar button and let it as the entry point of the games to the end-users. Related files are gameCenter.js and gameCenter.html. In the game center, all the games enabled by the admin will be rendered here as a game list.
AppExternalComponentManager
As you suggested before, I let AppExternalComponentManager maintain the game list itself. And the Rocket.Chat side, I expose the provided components by adding the method getGames and the rest api app/games.
game modal
To load each game according to its URL, I created a gameModal.js and gameModal.html to do such a thing. When I clicked a game item in the game center, Rocket.Chat will open the game modal
to load the game.