Skip to content

[FIX] Inject code at the end of <head> tag#14623

Merged
ggazzo merged 2 commits intodevelopfrom
fix/head-injections
May 24, 2019
Merged

[FIX] Inject code at the end of <head> tag#14623
ggazzo merged 2 commits intodevelopfrom
fix/head-injections

Conversation

@tassoevan
Copy link
Copy Markdown
Member

Closes #14548
Related to #14375

It introduces two helpers, injectIntoHead() and injectIntoBody(), to replace direct calls to Inject (meteor/meteorhacks:inject-initial) API.

@tassoevan tassoevan added type: bug area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction labels May 24, 2019
@tassoevan tassoevan added this to the 1.1.0 milestone May 24, 2019
@tassoevan tassoevan requested review from ggazzo and sampaiodiego May 24, 2019 17:18
@cenicoemir cenicoemir mentioned this pull request May 24, 2019
6 tasks
@ggazzo ggazzo merged commit 93dfe42 into develop May 24, 2019
@ggazzo ggazzo deleted the fix/head-injections branch May 24, 2019 18:39
wreiske added a commit to wreiske/Rocket.Chat that referenced this pull request May 27, 2019
… into new-reports-ui

* 'new-reports-ui' of https://github.com/wreiske/Rocket.Chat: (97 commits)
  LingoHub Update 🚀 (RocketChat#14643)
  [FIX] Role name spacing on Permissions page (RocketChat#14625)
  [FIX] Avatar images on old Livechat client (RocketChat#14590)
  [FIX] Inject code at the end of <head> tag (RocketChat#14623)
  [FIX] Mailer breaking if user doesn't have an email address (RocketChat#14614)
  Ci improvements (RocketChat#14600)
  [FIX] E2E messages not decrypting in message threads (RocketChat#14580)
  Fix: emoji render performance for alias (RocketChat#14593)
  [FIX] Send replyTo for livechat offline messages (RocketChat#14568)
  Federation i18n message changes (RocketChat#14595)
  [REGRESSION] Fix Slack bridge channel owner on channel creation (RocketChat#14565)
  Fix thumbs up emoji shortname (RocketChat#14581)
  Fix broken logo url in app.json (RocketChat#14572)
  Add digitalocean button to readme (RocketChat#14583)
  Fix: Add emoji shortnames to emoji's list (RocketChat#14576)
  [IMPROVE] Message rendering time (RocketChat#14252)
  [IMPROVE] Change user presence events to Meteor Streams (RocketChat#14488)
  Removed unnecessary DDP unblocks (RocketChat#13641)
  [FIX] Downloading files when running in sub directory (RocketChat#14485)
  [FIX] Broken layout when sidebar is open on IE/Edge (RocketChat#14567)
  ...
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
@engelgabriel
Copy link
Copy Markdown
Member

#14621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom styling is impossible/impractical to use on recent versions

3 participants