[IMPROVE] Add an optional rocketchat-protocol DNS entry for Federation#14589
Merged
sampaiodiego merged 3 commits intodevelopfrom May 30, 2019
Merged
[IMPROVE] Add an optional rocketchat-protocol DNS entry for Federation#14589sampaiodiego merged 3 commits intodevelopfrom
sampaiodiego merged 3 commits intodevelopfrom
Conversation
| // If there is no record, skip | ||
| if (!txtRecord) { | ||
| throw new Meteor.Error('ENOTFOUND', 'Could not find public key entry on TXT records'); | ||
| protocol = protocolTxtRecords[0][0].toLowerCase() === 'http' ? 'http' : 'https'; |
Contributor
There was a problem hiding this comment.
is [0][0] always guaranteed to be here? Should we check here or are we ok with this pattern of just "handling" / ignoring the exception that is thrown?
Member
There was a problem hiding this comment.
from node docs it seems to br guaranteed
sampaiodiego
approved these changes
May 30, 2019
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs in: https://github.com/RocketChat/docs/pull/1307