[FIX] Custom scripts descriptions were not clear enough #14516
Merged
[FIX] Custom scripts descriptions were not clear enough #14516
Conversation
Member
|
@MarcosSpessatto this is not the intent for this script, it should run always for logged out clients, for example, for people in login screen. |
Contributor
Author
|
Oh okay, the bug related is not a bug then. It's an error on script. I think we can close this then, What do you think? |
Contributor
|
Yeah this may be a case we need to tweak the description to make more clear some how what that script field can be used for |
Member
|
@MarcosSpessatto what if you change this PR to improve the field description? |
MarcosSpessatto
changed the title
rodrigok
approved these changes
May 16, 2019
rodrigok
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14436