Closed
Conversation
Contributor
alansikora
commented
May 9, 2019
- Made sure development environment does not use production federation hub;
- Organized some files;
- Added federation statistics;
geekgonecrazy
requested changes
May 10, 2019
Contributor
geekgonecrazy
left a comment
There was a problem hiding this comment.
looks like overall something went nuts reformatting. 😬
2321367 to
36df59b
Compare
Contributor
Author
|
@geekgonecrazy you can check again |
geekgonecrazy
previously approved these changes
May 13, 2019
Contributor
|
@sampaiodiego what do you want to do about these linting errors? It is griping about: Seems to only happen if a single import on its own line. If there are two in a row it stops |
be1fd31 to
08894e6
Compare
Contributor
Author
|
@geekgonecrazy that does not happen locally |
Member
|
@geekgonecrazy there are few import groups that cannot have empty lines between those imports. Usually they'll be external and internal imports, they need to separate by an empty line, but cannot have empty lines within the group, like: import _ from 'underscore';
import { Meteor } from 'meteor/meteor';
import { anything } from './internal/path';
import { other } from './internal/other'; |
Co-Authored-By: Diego Sampaio <[email protected]>
Contributor
|
Is this coming in 1.1.0 or being delayed to 1.2.0? |
Member
|
delayed to 1.2.0 |
Contributor
Author
|
@sampaiodiego I will close this one, you can reopen if you wish, but this is not relevant anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.