[FIX] Edit Message when down arrow is pressed.#14369
Merged
rodrigok merged 4 commits intoRocketChat:developfrom May 20, 2019
Merged
[FIX] Edit Message when down arrow is pressed.#14369rodrigok merged 4 commits intoRocketChat:developfrom
rodrigok merged 4 commits intoRocketChat:developfrom
Conversation
Contributor
Author
|
@rodrigok please review. This is a very small change. |
tassoevan
added
area: ui/ux
Member
|
I've found some other issues, like some messages been skipped. I removed the |
rodrigok
approved these changes
May 20, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14240.
Issue:
editByIndexfunction actually sets the index property of the editing object if it isundefined, which is useful in the case of pressing up arrow but not in the case of pressing down arrow.Resolution: Check if the message is being edited, only then allow it to be processed further.