[FIX] Optional exit on Unhandled Promise Rejection#14291
Merged
Conversation
graywolf336
previously approved these changes
Apr 28, 2019
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
While I understand what we were trying to achieve before this commit, I think it was a significant oversight to release it without verifying several internal and external packages don't correctly catch their own, and others, promises.
Contributor
|
There was far too much rushing to get this release out. |
rodrigok
approved these changes
Apr 28, 2019
rodrigok
pushed a commit
that referenced
this pull request
Apr 28, 2019
* unhandledpromiserejection error logs * linting * also exit if development environment
Closed
rodrigok
pushed a commit
that referenced
this pull request
Apr 29, 2019
* unhandledpromiserejection error logs * linting * also exit if development environment
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.