Improve: Marketplace auth inside Rocket.Chat instead of inside the iframe. #14258
Merged
Improve: Marketplace auth inside Rocket.Chat instead of inside the iframe. #14258
Conversation
…ecure. Refactored the cloud page. Changed menu to cloud connect, add button for cloud console and many others
Contributor
Author
|
@rocketchat/core Please let me know if you need help testing, or if any changes need made. |
rodrigok
approved these changes
Apr 27, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oauth inside of iframe requires us to weaken security on cloud side. So instead moving to do oauth in Rocket.Chat. Passing a short lived token to marketplace.
Refactored the cloud page more. Ideally making it easier to understand the need. Changed menu to cloud connect, add button for cloud console and many others
Added a login button to the marketplace page:
If you click purchase and you aren't logged in or your server isn't registered you'll see this:
Now if the server isn't registered it won't show them a login page they won't have a login for, which will hopefully reduce confusion a lot.
This should be the last time this is visited before 1.0