Skip to content

Regression: System messages styling#14189

Merged
ggazzo merged 5 commits intodevelopfrom
fix/system-messages
Apr 22, 2019
Merged

Regression: System messages styling#14189
ggazzo merged 5 commits intodevelopfrom
fix/system-messages

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Apr 18, 2019

This PR removes .collapsed class from system messages and it modifies the .system class itself.

Bugs addressed:

  • grouping should ignore system messages
  • inline-flex display in the message body is ignoring spaces around span elements
  • attachments are hidden

@tassoevan tassoevan added area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction feat: message type: regression labels Apr 18, 2019
@tassoevan tassoevan added this to the 1.0.0 milestone Apr 18, 2019
@tassoevan tassoevan requested review from ggazzo and rodrigok April 18, 2019 19:09
ggazzo
ggazzo requested changes Apr 22, 2019
View reviewed changes
@ggazzo ggazzo merged commit 9d211f3 into develop Apr 22, 2019
@ggazzo ggazzo deleted the fix/system-messages branch April 22, 2019 21:45
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees

No one assigned

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction feat: message

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tassoevan @ggazzo @rodrigok