Skip to content

Prevent error on normalize thread message for preview#14170

Merged
sampaiodiego merged 1 commit intodevelopfrom
fix/normalize-thread-message
Apr 17, 2019
Merged

Prevent error on normalize thread message for preview#14170
sampaiodiego merged 1 commit intodevelopfrom
fix/normalize-thread-message

Conversation

@tassoevan
Copy link
Copy Markdown
Member

When a thread message has no msg and all its attachments have neither title nor description, the preview fails.

@tassoevan tassoevan added type: bug area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction feat: threads / discussions labels Apr 17, 2019
@tassoevan tassoevan added this to the 1.0.0 milestone Apr 17, 2019
@tassoevan tassoevan requested a review from sampaiodiego April 17, 2019 13:45
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the error, but the check is welcome anyways =)

@sampaiodiego sampaiodiego merged commit c46c81f into develop Apr 17, 2019
@sampaiodiego sampaiodiego deleted the fix/normalize-thread-message branch April 17, 2019 18:28
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants