[FIX] Autogrow not working properly for many message boxes#14163
Merged
[FIX] Autogrow not working properly for many message boxes#14163
Conversation
tassoevan
added
type: bug
area: ui/ux
ggazzo
requested changes
Apr 17, 2019
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
please let me know if my question make sense :)
ggazzo
previously approved these changes
Apr 23, 2019
Member
|
@tassoevan could you fix the conflicts? |
ggazzo
approved these changes
Apr 25, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in width and height across many
messageBoxinstances weren't patched into the shared autogrow shadow<div>. Keeping one shadow to eachmessageBoxdid the trick, but destroying the shadow when the<textarea>is destroyed couldn't be accomplished in vanilla JS; therefore relying on Blaze to handle it was the chosen option.