[FIX] updating a message from apps if keep history is on#14127
Closed
sampaiodiego wants to merge 1 commit intomasterfrom
Closed
[FIX] updating a message from apps if keep history is on#14127sampaiodiego wants to merge 1 commit intomasterfrom
sampaiodiego wants to merge 1 commit intomasterfrom
Conversation
This was referenced Apr 12, 2019
Member
Author
|
Closing as the fix is already included in latest stable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for a release
0.74.4that's why it is targetingmasterbranch.The issue is
cloneAndSaveAsHistoryByIdis callingMeteor.userId()which will only work when invoked by a Meteor method. But Apps also update messages, soMeteor.userId()will fail.