[Fix] group name appears instead of the room id#14075
Merged
ggazzo merged 5 commits intoRocketChat:developfrom Apr 29, 2019
Merged
[Fix] group name appears instead of the room id#14075ggazzo merged 5 commits intoRocketChat:developfrom
ggazzo merged 5 commits intoRocketChat:developfrom
Conversation
mohamedar97
changed the title
This reverts commit 2078abd.
sampaiodiego
previously requested changes
Apr 10, 2019
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
thanks for you contribution.. while this works for discussions, it might not work for regular rooms.
the correct way to get a room's name is using roomTypes.getRoomName ..
Contributor
Author
|
i think that fixes it? |
Member
|
@mohamedar97 could you fix the issue to complete the build? :) |
ggazzo
approved these changes
Apr 29, 2019
ggazzo
dismissed
sampaiodiego’s stale review
[Fix] group name appears instead of the room id (#14075)
rodrigok
pushed a commit
that referenced
this pull request
Apr 30, 2019
* removed quote option from message options * modifications to show discussion name instead of the id when removing the user * Revert "removed quote option from message options" This reverts commit 2078abd. * modifications for implementing * liniting fixes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14064