Skip to content

Update badges and mention links colors#14071

Merged
rodrigok merged 6 commits intodevelopfrom
fix/room-bugs
Apr 16, 2019
Merged

Update badges and mention links colors#14071
rodrigok merged 6 commits intodevelopfrom
fix/room-bugs

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Apr 9, 2019

Captura de tela de 2019-04-12 17-59-15

@tassoevan tassoevan added type: bug area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction labels Apr 9, 2019
@tassoevan tassoevan added this to the 1.0.0 milestone Apr 9, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14071 April 9, 2019 18:36 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14071 April 9, 2019 21:49 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14071 April 10, 2019 18:38 Inactive
@RocketChat RocketChat deleted a comment Apr 10, 2019
@rodrigok
Copy link
Copy Markdown
Member

@tassoevan is this ready to be reviewed?

@tassoevan tassoevan changed the title Some room-related bugs Update badges and mention links colors Apr 12, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14071 April 12, 2019 03:52 Inactive
@tassoevan
Copy link
Copy Markdown
Member Author

@rodrigok Previous commits were broken into single PRs for faster code review, and I want to review the new color palette with @thiagosanchz before considering it ready to merge.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14071 April 12, 2019 20:31 Inactive
@tassoevan tassoevan marked this pull request as ready for review April 12, 2019 21:05
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait answers for my questions before approving =)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14071 April 15, 2019 20:20 Inactive
@rodrigok rodrigok merged commit ee9d8c0 into develop Apr 16, 2019
@rodrigok rodrigok deleted the fix/room-bugs branch April 16, 2019 17:35
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants