Skip to content

[IMPROVEMENT] Add tooltip to to notify user the purpose of back button in discussion#13872

Merged
ggazzo merged 7 commits intoRocketChat:developfrom
ashwaniYDV:issue6
May 16, 2019
Merged

[IMPROVEMENT] Add tooltip to to notify user the purpose of back button in discussion#13872
ggazzo merged 7 commits intoRocketChat:developfrom
ashwaniYDV:issue6

Conversation

@ashwaniYDV
Copy link
Copy Markdown
Contributor

@ashwaniYDV ashwaniYDV commented Mar 23, 2019

Closes #13871

Before Adding tooltip
before

After adding tooltip
qwer

Copy link
Copy Markdown
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a dictionary key... what do you think about using 'back_to_room' ?

@ashwaniYDV
Copy link
Copy Markdown
Contributor Author

@ggazzo I have used the dictionary key as you stated. It's more general now. Thank you for this advice.

@ggazzo ggazzo added this to the 1.0.0 milestone Apr 4, 2019
@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 6, 2019
@ggazzo ggazzo merged commit d9aa8eb into RocketChat:develop May 16, 2019
@ggazzo ggazzo changed the title [NEW] Add tooltip to to notify user the purpose of back button in discussion [IMPROVEMENT] Add tooltip to to notify user the purpose of back button in discussion May 16, 2019
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion room's back button does not specify its action

4 participants