[BUG] Icon Fixed for Knowledge base on Livechat #13806
[BUG] Icon Fixed for Knowledge base on Livechat #13806engelgabriel merged 2 commits intoRocketChat:developfrom
Conversation
|
@knrt10 There is a small typo in app/ui-master/public/README.md (line 5):-
|
|
Thanks @ashwaniYDV for pointing that out |
engelgabriel
left a comment
engelgabriel
left a comment
There was a problem hiding this comment.
@knrt10 The SVG needs to be flattened into a single path, do you know how to do that?
|
@brunosquadros can you help with the right icon here? |
|
Should we use
|
IMO, the second one looks better. |
|
The light bulb is more about creativity than knowledge, IMHO |
|
@engelgabriel please tell me about which icon to use book or bulb, I will convert it into a single path |
|
@engelgabriel The lightbulb looks great, but the book is more adequate in this context. |
|
Converting to one path. This is lightbulb
and this is book
|
|
The book works better for this context, I've adapted a path that one from FontAwesome. |
|
Cool, let me update the PR then |
|
Updated the PR. Logo
cc @tassoevan would you please review |
tassoevan
left a comment
tassoevan
left a comment
There was a problem hiding this comment.
The lightbulb icon must be removed from this PR or redesigned since its size doesn't match our standard (20x20).
|
Done @tassoevan |
6 participants
Closes #13797
Icon fixed, along that updated instructions to add and update new icons for RC.
cc @renatobecker @tassoevan would you please review